-
Notifications
You must be signed in to change notification settings - Fork 5
Added production of fungal fruiting bodies #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… based on changes in the animal model
…ungal fruiting body decay
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #948 +/- ##
===========================================
+ Coverage 94.08% 94.25% +0.16%
===========================================
Files 78 79 +1
Lines 6172 6404 +232
===========================================
+ Hits 5807 6036 +229
- Misses 365 368 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pretty long PR, but I think all makes sense and is clear. This is becoming more complicated by the minute...
Yes this is the last addition that I intended to make to the soil model before moving onto bug-fixing and calibration, so this should be as most complex as the soil model gets 🤞 |
…veraging to docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animal content looks good to me!
Description
This PR adds production of fruiting bodies by soil fungi. On the soil side this change is fairly straightforward, fungi allocate a certain proportion of their new biomass to fruiting body production in the same way that they allocate to enzyme production. The production rate across all fungal groups is then summed and passed to the animal model.
The animal model stores the mass of fruiting bodies as a scavengable pool. As well as scavenging the animal model also updates this pool based on the input of new fruiting body biomass from the soil model, and the decay of fruiting bodies. This decay gets passed back to the soil model as low molecular weight carbon (and the equivalent forms of nitrogen and phosphorus). At each time step the animal model also updates the fungal fruiting body abundance in the data object.
@TaranRallings, I've added a reasonable amount of code to the animal model here, so let me know if you are happy with the changes.
Fixes #932. Fixes #907
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks