feat(core): make caption formatters accept a list instead of a collection, some things may rely on order (#681)

Author: jpenilla

cloud-core/src/main/java/org/incendo/cloud/caption/CaptionFormatter.java

@@ -24,8 +24,8 @@
 package org.incendo.cloud.caption;
 
 import java.util.Arrays;
-import java.util.Collection;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -102,7 +102,7 @@ static Pattern placeholderPattern() {
             @NonNull Caption captionKey,
             @NonNull C recipient,
             @NonNull String caption,
-            @NonNull Collection<@NonNull CaptionVariable> variables
+            @NonNull List<@NonNull CaptionVariable> variables
     );
 
 
@@ -119,7 +119,7 @@ private PatternReplacingCaptionFormatter(final @NonNull Pattern pattern) {
                 final @NonNull Caption captionKey,
                 final @NonNull C recipient,
                 final @NonNull String caption,
-                final @NonNull Collection<@NonNull CaptionVariable> variables
+                final @NonNull List<@NonNull CaptionVariable> variables
         ) {
             final Map<String, String> replacements = new HashMap<>();
             for (final CaptionVariable variable : variables) {

cloud-core/src/main/java/org/incendo/cloud/context/CommandContext.java

@@ -24,7 +24,6 @@
 package org.incendo.cloud.context;
 
 import io.leangen.geantyref.TypeToken;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedList;
@@ -120,7 +119,7 @@ public CommandContext(
      */
     public @NonNull String formatCaption(
             final @NonNull Caption caption,
-            final @NonNull Collection<@NonNull CaptionVariable> variables
+            final @NonNull List<@NonNull CaptionVariable> variables
     ) {
         return this.formatCaption(this.commandManager.captionFormatter(), caption, variables);
     }
@@ -159,7 +158,7 @@ public CommandContext(
     public <T> @NonNull T formatCaption(
             final @NonNull CaptionFormatter<C, T> formatter,
             final @NonNull Caption caption,
-            final @NonNull Collection<@NonNull CaptionVariable> variables
+            final @NonNull List<@NonNull CaptionVariable> variables
     ) {
         return formatter.formatCaption(
                 caption,