fix style

Author: jpenilla

cloud-core/src/main/java/org/incendo/cloud/CommandManager.java

@@ -112,7 +112,7 @@ public abstract class CommandManager<C> implements Stateful<RegistrationState>,
     private final Set<CloudCapability> capabilities = new HashSet<>();
     private final ExceptionController<C> exceptionController = new ExceptionController<>();
     private final CommandExecutor<C> commandExecutor;
-    final ThreadLocalPermissionCache<C> threadLocalPermissionCache = new ThreadLocalPermissionCache<>(this.settings);
+    private final ThreadLocalPermissionCache<C> threadLocalPermissionCache = new ThreadLocalPermissionCache<>(this.settings);
 
     private CaptionFormatter<C, String> captionVariableReplacementHandler = CaptionFormatter.placeholderReplacing();
     private CommandSyntaxFormatter<C> commandSyntaxFormatter = new StandardCommandSyntaxFormatter<>(this);
@@ -178,6 +178,10 @@ protected CommandManager(
         return this.commandExecutor;
     }
 
+    final @NonNull ThreadLocalPermissionCache<C> threadLocalPermissionCache() {
+        return this.threadLocalPermissionCache;
+    }
+
     /**
      * Returns the suggestion factory.
      *
@@ -392,26 +396,26 @@ public boolean hasCapability(final @NonNull CloudCapability capability) {
             final @NonNull C sender,
             final @NonNull Permission permission
     ) {
-        return this.threadLocalPermissionCache.withPermissionCache(() -> this.testPermission_(sender, permission));
+        return this.threadLocalPermissionCache.withPermissionCache(() -> this.testPermissionRaw(sender, permission));
     }
 
     @SuppressWarnings("unchecked")
-    private @NonNull PermissionResult testPermission_(final @NonNull C sender, final @NonNull Permission permission) {
+    private @NonNull PermissionResult testPermissionRaw(final @NonNull C sender, final @NonNull Permission permission) {
         if (permission instanceof PredicatePermission) {
             return this.threadLocalPermissionCache.testPermissionCaching(sender, (PredicatePermission<C>) permission, pair -> {
                 return pair.second().testPermission(pair.first());
             });
         } else if (permission instanceof OrPermission) {
             for (final Permission innerPermission : permission.permissions()) {
-                final PermissionResult result = this.testPermission_(sender, innerPermission);
+                final PermissionResult result = this.testPermissionRaw(sender, innerPermission);
                 if (result.allowed()) {
                     return result;
                 }
             }
             return PermissionResult.denied(permission);
         } else if (permission instanceof AndPermission) {
             for (final Permission innerPermission : permission.permissions()) {
-                final PermissionResult result = this.testPermission_(sender, innerPermission);
+                final PermissionResult result = this.testPermissionRaw(sender, innerPermission);
                 if (!result.allowed()) {
                     return result;
                 }

cloud-core/src/main/java/org/incendo/cloud/CommandTree.java

@@ -357,7 +357,7 @@ private Exception noPermissionOrSyntax(
             );
         }
 
-        return this.commandManager.threadLocalPermissionCache.withPermissionCache(() -> {
+        return this.commandManager.threadLocalPermissionCache().withPermissionCache(() -> {
             if (this.childPermitted(root, sender)) {
                 return new InvalidSyntaxException(
                         this.commandManager.commandSyntaxFormatter().apply(sender, (List) this.getComponentChain(root), root),

cloud-core/src/main/java/org/incendo/cloud/internal/ThreadLocalPermissionCache.java

@@ -38,14 +38,27 @@
 
 @API(status = API.Status.INTERNAL)
 public final class ThreadLocalPermissionCache<C> {
+
     private final ThreadLocal<Pair<Map<Pair<C, Permission>, PermissionResult>, AtomicInteger>> threadLocalPermissionCache =
             ThreadLocal.withInitial(() -> Pair.of(new HashMap<>(), new AtomicInteger(0)));
     private final Configurable<ManagerSetting> settings;
 
+    /**
+     * Create a new cache.
+     *
+     * @param settings settings
+     */
     public ThreadLocalPermissionCache(final Configurable<ManagerSetting> settings) {
         this.settings = settings;
     }
 
+    /**
+     * Perform an action in a cached scope.
+     *
+     * @param action action
+     * @param <T>    result type
+     * @return result
+     */
     public <T> T withPermissionCache(final Supplier<T> action) {
         final boolean cache = this.settings.get(ManagerSetting.REDUCE_REDUNDANT_PERMISSION_CHECKS);
         try {
@@ -67,6 +80,15 @@ public <T> T withPermissionCache(final Supplier<T> action) {
         }
     }
 
+    /**
+     * Test permission caching.
+     *
+     * @param sender     sender
+     * @param permission permission
+     * @param tester     tester
+     * @param <T>        permission type
+     * @return permission result
+     */
     @SuppressWarnings({"rawtypes", "unchecked"})
     public @NonNull <T> PermissionResult testPermissionCaching(
             final @NonNull C sender,