fix: bigInt seralization - canary

Author: ThomasRalee

.github/workflows/dev.yaml

@@ -63,14 +63,26 @@ jobs:
         with:
           version: latest
 
-      # OIDC trusted publishing requires npm 11.5.1+
-      - name: Update npm for OIDC trusted publishing
-        run: npm install -g npm@latest
+      - name: Get pnpm store directory
+        shell: bash
+        run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
+      - name: Setup pnpm cache
+        uses: actions/cache@v4
+        with:
+          path: ${{ env.STORE_PATH }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
 
-      - name: Set up Git user
+      # OIDC trusted publishing requires npm 11.5.1+
+      - name: Update npm and set up Git user
         run: |
+          npm install -g npm@latest &
+          NPM_PID=$!
           git config user.name "${{ github.actor }}"
           git config user.email "${{ github.actor }}@users.noreply.github.com"
+          wait $NPM_PID || { echo "::error::Failed to update npm"; exit 1; }
 
       - name: Determine publish type
         id: determine-publish-type
@@ -131,35 +143,76 @@ jobs:
       - name: Publish to npm (OIDC)
         run: |
           DIST_TAG="${{ steps.determine-publish-type.outputs.dist_tag }}"
-          PUBLISHED_PACKAGES="[]"
           ROOT_DIR="$(pwd)"
-          PUBLISH_COUNT=0
 
+          # Create a temporary directory for publish scripts
+          mkdir -p "$ROOT_DIR/.publish-tmp"
+
+          # Generate publish commands for all packages (use null delimiter for safety)
           for pkg_json in packages/*/package.json packages/wallets/*/package.json; do
             pkg_dir=$(dirname "$pkg_json")
             pkg_name=$(node -p "require('./$pkg_json').name")
             pkg_version=$(node -p "require('./$pkg_json').version")
-            
-            echo "📦 Publishing $pkg_name@$pkg_version"
+            tarball_name=$(echo "$pkg_name" | sed 's/@//;s/\//-/')-$pkg_version.tgz
             
             # Pack with pnpm to resolve catalog: dependencies
-            pnpm --dir "$pkg_dir" pack --pack-destination "$ROOT_DIR"
+            pnpm --dir "$pkg_dir" pack --pack-destination "$ROOT_DIR/.publish-tmp"
             
-            tarball_name=$(echo "$pkg_name" | sed 's/@//;s/\//-/')-$pkg_version.tgz
-            
-            if [ -f "$tarball_name" ]; then
-              if npm publish "$tarball_name" --access public --tag "$DIST_TAG" --provenance; then
-                PUBLISHED_PACKAGES=$(echo "$PUBLISHED_PACKAGES" | node -p "JSON.stringify([...JSON.parse(require('fs').readFileSync('/dev/stdin','utf8')), {name:'$pkg_name',version:'$pkg_version'}])")
-                PUBLISH_COUNT=$((PUBLISH_COUNT + 1))
-              fi
-              rm -f "$tarball_name"
+            if [ -f "$ROOT_DIR/.publish-tmp/$tarball_name" ]; then
+              # Use null delimiter to safely handle any package names
+              printf '%s\t%s\t%s\0' "$ROOT_DIR/.publish-tmp/$tarball_name" "$pkg_name" "$pkg_version" >> "$ROOT_DIR/.publish-tmp/packages.txt"
             else
               echo "⚠️ No tarball found for $pkg_name"
             fi
           done
 
+          # Publish packages in parallel (4 concurrent jobs)
+          RESULTS_FILE="$ROOT_DIR/.publish-tmp/results.txt"
+          FAILED_FILE="$ROOT_DIR/.publish-tmp/failed.txt"
+          touch "$RESULTS_FILE" "$FAILED_FILE"
+
+          publish_package() {
+            IFS=$'\t' read -r tarball pkg_name pkg_version <<< "$1"
+            echo "📦 Publishing $pkg_name@$pkg_version"
+            if npm publish "$tarball" --access public --tag "$DIST_TAG" --provenance 2>&1; then
+              echo "$pkg_name:$pkg_version" >> "$RESULTS_FILE"
+            else
+              echo "$pkg_name:$pkg_version" >> "$FAILED_FILE"
+              echo "::warning::Failed to publish $pkg_name@$pkg_version"
+            fi
+          }
+          export -f publish_package
+          export DIST_TAG RESULTS_FILE FAILED_FILE
+
+          # Run publishes in parallel using null delimiter for safety
+          if [ -f "$ROOT_DIR/.publish-tmp/packages.txt" ]; then
+            xargs -0 -P 4 -I {} bash -c 'publish_package "$@"' _ {} < "$ROOT_DIR/.publish-tmp/packages.txt"
+          fi
+
+          # Build results from file
+          PUBLISH_COUNT=$(wc -l < "$RESULTS_FILE" | tr -d ' ')
+          FAILED_COUNT=$(wc -l < "$FAILED_FILE" | tr -d ' ')
+
+          # Build JSON array efficiently
+          PUBLISHED_PACKAGES=$(node -e "
+            const fs = require('fs');
+            const lines = fs.readFileSync('$RESULTS_FILE', 'utf8').trim().split('\n').filter(Boolean);
+            const packages = lines.map(line => {
+              const [name, version] = line.split(':');
+              return { name, version };
+            });
+            console.log(JSON.stringify(packages));
+          ")
+
+          # Cleanup
+          rm -rf "$ROOT_DIR/.publish-tmp"
+
           echo "{\"publishedPackages\":$PUBLISHED_PACKAGES}" > pnpm-publish-summary.json
 
+          if [ "$FAILED_COUNT" -gt 0 ]; then
+            echo "::warning::$FAILED_COUNT package(s) failed to publish"
+          fi
+
           if [ "$PUBLISH_COUNT" -eq 0 ]; then
             echo "::error::No packages were published. Check npm OIDC trusted publisher configuration."
             exit 1
@@ -201,7 +254,7 @@ jobs:
   package-bump-hub:
     name: 'Package bump hub'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -218,7 +271,7 @@ jobs:
   package-bump-helix:
     name: 'Package bump Helix'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -235,7 +288,7 @@ jobs:
   package-bump-explorer:
     name: 'Package bump Explorer'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -252,7 +305,7 @@ jobs:
   package-bump-trading-ui:
     name: 'Package bump Trading UI'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -269,7 +322,7 @@ jobs:
   package-bump-mito:
     name: 'Package bump Mito'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -286,7 +339,7 @@ jobs:
   package-bump-ui-api:
     name: 'Package bump UI API'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -303,7 +356,7 @@ jobs:
   package-bump-admin-ui:
     name: 'Package bump Admin UI'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||
@@ -320,7 +373,7 @@ jobs:
   package-bump-do-ui:
     name: 'Package bump DO UI'
     runs-on: ubuntu-latest
-    needs: [publish, package-bump-layer]
+    needs: publish
     if: |
       always() &&
       (needs.publish.result == 'success' && needs.publish.outputs.publish_type == 'latest') ||

.husky/pre-push

@@ -1,76 +1,4 @@
 set -e
 
-# Check if local branch is behind remote and block push if so
-BRANCH=$(git rev-parse --abbrev-ref HEAD)
-REMOTE="origin"
-
-# Fetch latest from remote (only refs, no objects - much faster)
-git fetch --depth=1 --no-tags $REMOTE $BRANCH 2>/dev/null || true
-
-# Check if remote branch exists
-if git rev-parse --verify $REMOTE/$BRANCH >/dev/null 2>&1; then
-  LOCAL=$(git rev-parse HEAD)
-  REMOTE_HEAD=$(git rev-parse $REMOTE/$BRANCH)
-  BASE=$(git merge-base HEAD $REMOTE/$BRANCH)
-
-  if [ "$LOCAL" != "$REMOTE_HEAD" ] && [ "$BASE" = "$LOCAL" ]; then
-    echo ""
-    echo "ERROR: Your branch '$BRANCH' is behind '$REMOTE/$BRANCH'."
-    echo ""
-    echo "Please run: git pull --rebase"
-    echo ""
-    echo "This will replay your commits on top of the latest remote commits."
-    echo "If there are conflicts, resolve them and run: git rebase --continue"
-    echo ""
-    exit 1
-  fi
-
-  if [ "$LOCAL" != "$REMOTE_HEAD" ] && [ "$BASE" = "$REMOTE_HEAD" ]; then
-    # Local is ahead, this is fine - we're pushing new commits
-    :
-  elif [ "$LOCAL" != "$REMOTE_HEAD" ] && [ "$BASE" != "$LOCAL" ] && [ "$BASE" != "$REMOTE_HEAD" ]; then
-    echo ""
-    echo "ERROR: Your branch '$BRANCH' has diverged from '$REMOTE/$BRANCH'."
-    echo ""
-    echo "Please run: git pull --rebase"
-    echo ""
-    echo "This will replay your commits on top of the latest remote commits."
-    echo "If there are conflicts, resolve them and run: git rebase --continue"
-    echo ""
-    exit 1
-  fi
-fi
-
-# --- UNCOMMENT BELOW FOR AUTO-REBASE (instead of manual check above) ---
-# # Automatically run git pull --rebase if behind remote
-# BRANCH=$(git rev-parse --abbrev-ref HEAD)
-# REMOTE="origin"
-#
-# git fetch --depth=1 --no-tags $REMOTE $BRANCH 2>/dev/null || true
-#
-# if git rev-parse --verify $REMOTE/$BRANCH >/dev/null 2>&1; then
-#   LOCAL=$(git rev-parse HEAD)
-#   REMOTE_HEAD=$(git rev-parse $REMOTE/$BRANCH)
-#   BASE=$(git merge-base HEAD $REMOTE/$BRANCH)
-#
-#   if [ "$LOCAL" != "$REMOTE_HEAD" ] && [ "$BASE" != "$REMOTE_HEAD" ]; then
-#     echo ""
-#     echo "Your branch is behind or has diverged. Running git pull --rebase..."
-#     echo ""
-#     if ! git pull --rebase $REMOTE $BRANCH; then
-#       echo ""
-#       echo "ERROR: Rebase failed due to conflicts."
-#       echo "Please resolve conflicts and run: git rebase --continue"
-#       echo "Then try pushing again."
-#       echo ""
-#       exit 1
-#     fi
-#     echo ""
-#     echo "Rebase successful. Continuing with push..."
-#     echo ""
-#   fi
-# fi
-# --- END AUTO-REBASE ---
-
-pnpm lint
-pnpm build
+pnpm lint || exit 1
+pnpm build || exit 1

packages/sdk-ts/src/client/indexer/grpc/IndexerGrpcTransactionApi.ts

@@ -14,6 +14,7 @@ import {
   DEFAULT_BRIDGE_FEE_PRICE,
 } from '@injectivelabs/utils'
 import { IndexerModule } from '../types/index.js'
+import { safeBigIntStringify } from '../../../utils/helpers.js'
 import { recoverTypedSignaturePubKey } from '../../../utils/transaction.js'
 import BaseIndexerGrpcConsumer from '../../base/BaseIndexerGrpcConsumer.js'
 import {
@@ -79,7 +80,7 @@ export class IndexerGrpcTransactionApi extends BaseIndexerGrpcConsumer {
 
     const arrayOfMessages = Array.isArray(message) ? message : [message]
     const messagesList = arrayOfMessages.map((message) =>
-      stringToUint8Array(JSON.stringify(message)),
+      stringToUint8Array(safeBigIntStringify(message)),
     )
 
     prepareTxRequest.msgs = messagesList
@@ -144,7 +145,7 @@ export class IndexerGrpcTransactionApi extends BaseIndexerGrpcConsumer {
 
     const arrayOfMessages = Array.isArray(message) ? message : [message]
     const messagesList = arrayOfMessages.map((message) =>
-      stringToUint8Array(JSON.stringify(message)),
+      stringToUint8Array(safeBigIntStringify(message)),
     )
 
     prepareTxRequest.msgs = messagesList
@@ -211,7 +212,7 @@ export class IndexerGrpcTransactionApi extends BaseIndexerGrpcConsumer {
     broadcastTxRequest.pubKey = cosmosPubKey
     broadcastTxRequest.signature = signature
     broadcastTxRequest.tx = stringToUint8Array(
-      JSON.stringify(parsedTypedData.message),
+      safeBigIntStringify(parsedTypedData.message),
     )
 
     broadcastTxRequest.feePayer = txResponse.feePayer
@@ -220,7 +221,7 @@ export class IndexerGrpcTransactionApi extends BaseIndexerGrpcConsumer {
     const arrayOfMessages = Array.isArray(message) ? message : [message]
 
     const messagesList = arrayOfMessages.map((message) =>
-      stringToUint8Array(JSON.stringify(message)),
+      stringToUint8Array(safeBigIntStringify(message)),
     )
 
     broadcastTxRequest.msgs = messagesList

packages/sdk-ts/src/client/indexer/grpc/IndexerGrpcWeb3GwApi.ts

@@ -7,6 +7,7 @@ import {
 } from '@injectivelabs/utils'
 import { IndexerModule } from '../types/index.js'
 import { stringToUint8Array } from '../../../utils/encoding.js'
+import { safeBigIntStringify } from '../../../utils/helpers.js'
 import { IndexerGrpcTransactionApi } from './IndexerGrpcTransactionApi.js'
 import type { EvmChainId, AccountAddress } from '@injectivelabs/ts-types'
 
@@ -67,11 +68,7 @@ export class IndexerGrpcWeb3GwApi extends IndexerGrpcTransactionApi {
 
     const arrayOfMessages = Array.isArray(message) ? message : [message]
     const messagesList = arrayOfMessages.map((message) =>
-      stringToUint8Array(
-        JSON.stringify(message, (_, value) =>
-          typeof value === 'bigint' ? value.toString() : value,
-        ),
-      ),
+      stringToUint8Array(safeBigIntStringify(message)),
     )
 
     prepareTxRequest.msgs = messagesList

packages/sdk-ts/src/core/modules/authz/msgs/MsgGrant.spec.ts

@@ -104,6 +104,16 @@ describe('MsgGrant', () => {
     })
   })
 
+  it('generates JSON without BigInt serialization error', () => {
+    expect(() => message.toJSON()).not.toThrow()
+
+    const json = message.toJSON()
+    const parsed = JSON.parse(json)
+
+    expect(typeof parsed.grant.expiration.seconds).toBe('string')
+    expect(parsed.grant.expiration.seconds).toBe(params.expiration!.toString())
+  })
+
   describe('generates proper EIP712 compared to the Web3Gw (chain)', () => {
     const { endpoints, eip712Args, prepareEip712Request } = prepareEip712({
       messages: message,