Skip to content

Commit 5b762eb

Browse files
committed
feat: remove unused exchange client dependency
1 parent ca4abcb commit 5b762eb

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

client/chain/markets_assistant.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"github.com/shopspring/decimal"
99

1010
"github.com/InjectiveLabs/sdk-go/client/core"
11-
"github.com/InjectiveLabs/sdk-go/client/exchange"
1211
)
1312

1413
type TokenMetadata interface {
@@ -56,15 +55,19 @@ func NewHumanReadableMarketsAssistant(ctx context.Context, chainClient ChainClie
5655
return assistant, err
5756
}
5857

59-
func NewMarketsAssistantWithAllTokens(ctx context.Context, exchangeClient exchange.ExchangeClient, chainClient ChainClient) (MarketsAssistant, error) {
58+
// NewMarketsAssistantWithAllTokens initializes a MarketsAssistant by first fetching all token metadata from the chain's bank module
59+
// @deprecated remove deprecated
60+
func NewMarketsAssistantWithAllTokens(ctx context.Context, exchangeClient any, chainClient ChainClient) (MarketsAssistant, error) {
6061
assistant := newMarketsAssistant()
6162
assistant.initializeTokensFromChainDenoms(ctx, chainClient)
6263
err := assistant.initializeFromChainV1Markets(ctx, chainClient)
6364

6465
return assistant, err
6566
}
6667

67-
func NewHumanReadableMarketsAssistantWithAllTokens(ctx context.Context, exchangeClient exchange.ExchangeClient, chainClient ChainClientV2) (MarketsAssistant, error) {
68+
// NewHumanReadableMarketsAssistantWithAllTokens initializes a MarketsAssistant by first fetching all token metadata from the chain's bank module
69+
// @deprecated remove exchangeClient
70+
func NewHumanReadableMarketsAssistantWithAllTokens(ctx context.Context, exchangeClient any, chainClient ChainClientV2) (MarketsAssistant, error) {
6871
assistant := newMarketsAssistant()
6972
assistant.initializeTokensFromChainDenoms(ctx, chainClient)
7073
err := assistant.initializeFromChainV2Markets(ctx, chainClient)

client/chain/markets_assistant_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
exchangev2types "github.com/InjectiveLabs/sdk-go/chain/exchange/types/v2"
1717
"github.com/InjectiveLabs/sdk-go/client/common"
1818
"github.com/InjectiveLabs/sdk-go/client/core"
19-
"github.com/InjectiveLabs/sdk-go/client/exchange"
2019
)
2120

2221
func TestMarketAssistantCreation(t *testing.T) {
@@ -179,8 +178,6 @@ func TestMarketAssistantCreationWithAllTokens(t *testing.T) {
179178
network := common.NewNetwork()
180179
network.OfficialTokensListURL = httpServer.URL
181180

182-
mockExchange := exchange.MockExchangeClient{}
183-
mockExchange.Network = network
184181
mockChain := MockChainClient{}
185182
smartDenomMetadata := createSmartDenomMetadata()
186183

@@ -193,7 +190,7 @@ func TestMarketAssistantCreationWithAllTokens(t *testing.T) {
193190
})
194191

195192
ctx := context.Background()
196-
assistant, err := NewMarketsAssistantWithAllTokens(ctx, &mockExchange, &mockChain)
193+
assistant, err := NewMarketsAssistantWithAllTokens(ctx, nil, &mockChain)
197194

198195
assert.NoError(t, err)
199196

@@ -365,8 +362,6 @@ func TestHumanReadableMarketAssistantCreationWithAllTokens(t *testing.T) {
365362
network := common.NewNetwork()
366363
network.OfficialTokensListURL = httpServer.URL
367364

368-
mockExchange := exchange.MockExchangeClient{}
369-
mockExchange.Network = network
370365
mockChain := MockChainClientV2{}
371366
smartDenomMetadata := createSmartDenomMetadata()
372367

@@ -379,7 +374,7 @@ func TestHumanReadableMarketAssistantCreationWithAllTokens(t *testing.T) {
379374
})
380375

381376
ctx := context.Background()
382-
assistant, err := NewHumanReadableMarketsAssistantWithAllTokens(ctx, &mockExchange, &mockChain)
377+
assistant, err := NewHumanReadableMarketsAssistantWithAllTokens(ctx, nil, &mockChain)
383378

384379
assert.NoError(t, err)
385380

0 commit comments

Comments
 (0)