Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "Open the service" should use URL from the NOTES.txt #937

Closed
Gaspi opened this issue Feb 25, 2025 · 0 comments · Fixed by #938
Closed

Feature request: "Open the service" should use URL from the NOTES.txt #937

Gaspi opened this issue Feb 25, 2025 · 0 comments · Fixed by #938

Comments

@Gaspi
Copy link
Contributor

Gaspi commented Feb 25, 2025

Context

Currently the "Open the service" button links to the first URL found in the urls field from the /my-lab/app endpoint.
These urls are derived from the paths of the service's Ingresses/Routes (see ServiceUrlResolver.getServiceUrls)

Feature request

In some cases, the most user-friendly entry point is a subpath of the default URL provided by the service's Ingress/Route (e.g. https://my-service.domain.fr/dashboard).
This user-friendly URL is often specified in the NOTES. Ideally, the "Open the service" button should use this URL instead of the raw urls field from the API.

Implementation considerations

  • Only URLs from the NOTES that match one of the service's Ingresses/Routes (as provided by the API) should be considered.
  • If multiple matching URLs exist in NOTES, the first encountered match should be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant