Loss broadcasting fix #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to correct broadcasting issues due to shape mismatches in loss calculations.
This was brought on by the realization that broadcasting works a little differently (from some time ago) when tensor shapes are mismatched. In particular, labels come out of the pipeline with an extra dimension (e.g.
[N, 1]
) compared to graph readouts. The resulting behavior is actually very different from the intention:The code changes make it so that
_compute_losses
methods will check if model output and label shapes are mismatched, and if they are, attempt to reshape the model outputs to match the labels' shape before computing the loss.