add test cases for collection manager (#304)

* add test cases for collection manager

* [pre-commit.ci lite] apply automatic fixes

* Automated coverage update

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 3 people

.github/coverage/cpp.develop.coverage_report.txt

@@ -38,7 +38,7 @@ src/vcl/DescriptorSet.cc                     179     126    70%   65,69-70,93-94
 src/vcl/DescriptorSetData.cc                  55      47    85%   48,58,64,67,114,116-118
 src/vcl/Exception.cc                           7       6    85%   38
 src/vcl/FaissDescriptorSet.cc                212     183    86%   83,115-116,132,167,187-188,204-205,224-225,238-239,245,258-259,261,272-273,279,305-306,308-309,311,374-375,381,405
-src/vcl/Filter.cc                            132      90    68%   77,82,92-93,108-109,121-126,140-141,147-148,169-173,175,181-183,185,190-191,196-197,204-205,218-219,225-226,233,242,278,285,289-290
+src/vcl/Filter.cc                            132     102    77%   77,82,92-93,108-109,121-126,140-141,147-148,190-191,196-197,204-205,218-219,225-226,233,242,278,285
 src/vcl/FlinngDescriptorSet.cc               149     109    73%   60-66,89,109-111,113-114,118-121,124,126,128,130,132,134-137,140-141,143-144,170-171,176-177,182,206,208,228,248,279
 src/vcl/Image.cc                             924     692    74%   62,73-74,76-78,81-84,86,92,101,122-123,125,132-133,135,147,165,170,193,196-199,223,246,249-252,264,273,276-279,291,323,326-329,341,347,349-352,360-362,369,393-396,415,417,425,427,432,436,441,445,459,462,467-468,471-472,474,490,500,513,531,553-556,566,597,603-605,614-615,617,625,629,634,637-648,676-678,730,775-776,827,856-860,862-868,870,872-873,914,917-918,957-958,962-963,984,1003-1004,1006,1046-1048,1050-1054,1056-1060,1062-1066,1068-1072,1074-1078,1080-1083,1106,1127,1146-1154,1165-1166,1185-1204,1216-1217,1225,1236,1238-1240,1242-1244,1246,1264-1265,1267,1272-1273,1275,1296,1300,1303,1310,1325,1331,1340,1354,1379,1397,1480,1499
 src/vcl/KeyFrame.cc                          303     244    80%   58,62,86,90,95,97,102,105-107,109-111,113,119,139,148,154,172,186,190,216,220,224,235,239,249,255,274,284,288,307,315,341,345,347,359,367,369,394,396,405,430,442,449,465,469,478,483,495,500,507,514,518,525,541,547,557,563
@@ -63,5 +63,5 @@ utils/src/kubernetes/KubeHelper.cc           183      37    20%   23-30,32-35,37
 utils/src/stats/SystemStats.cc               250     249    99%   455
 utils/src/timers/TimerMap.cc                  82      74    90%   126,151,153,155-158,162
 ------------------------------------------------------------------------------
-TOTAL                                      11565    8050    69%
+TOTAL                                      11565    8062    69%
 ------------------------------------------------------------------------------

.github/coverage/cpp.develop.coverage_value.txt

@@ -1 +1 @@
-69.6066
+69.7103

include/vcl/Filter.h

@@ -302,19 +302,19 @@ class Filter {
   uint32_t get_num_keys() const { return num_keys_; }
   uint32_t get_ef() const { return extra_flag_; }
 
-  /**
-   * @brief Lists the names of all currently managed filters.
-   * @return A vector of strings, where each string is the name of an active
-   * filter.
-   * * Returns an empty vector if no filters are currently defined.
-   * */
-  std::vector<std::string> filter_list_all_names();
-
   // --- create instances of derived classes based on FilterParameters::engine
   // ---
   static UniqueFilterPtr create_filter_instance(const FilterParameters *params);
 };
 
+/**
+ * @brief Lists the names of all currently managed filters.
+ * @return A vector of strings, where each string is the name of an active
+ * filter.
+ * * Returns an empty vector if no filters are currently defined.
+ * */
+std::vector<std::string> filter_list_all_names();
+
 // =============================================================
 // Internal Filter Collection Management Class
 // This class is responsible for owning and managing the lifecycle

tests/unit_tests/Filter_test.cc

@@ -39,7 +39,22 @@ class FilterTest : public ::testing::Test {
     VCL::FilterParameters params_ht_max;
     VCL::FilterParameters params_cache_max;
 
+
+    static int filter_name_counter;
+    std::vector<std::string> filter_names;
+
+
     void SetUp() override {
+
+        // Clear any filters from previous tests to ensure clean state
+        // since filter_create adds to a global manager
+        std::vector<std::string> existing_filter_names = VCL::filter_list_all_names();
+        for (const std::string& name : existing_filter_names) {
+            VCL::filter_free(VCL::filter_find_existing(name.c_str()));
+        }
+
+        filter_names.clear();
+
         // Common parameters for small filters
         params_ht_small.num_keys = SMALL_NUM_KEYS;
         params_ht_small.key_len = TEST_KEY_LEN;
@@ -78,17 +93,157 @@ class FilterTest : public ::testing::Test {
     }
 
     void TearDown() override {
-        // No explicit teardown needed for unique_ptr or stack objects
+        // Free filters after test to prevent duplicate names
+        std::vector<std::string> existing_filter_names = VCL::filter_list_all_names();
+        for (const std::string& name : existing_filter_names) {
+            VCL::filter_free(VCL::filter_find_existing(name.c_str()));
+        }
+
+        filter_names.clear();
     }
 };
 
+int FilterTest::filter_name_counter = 0;
 
 /*
  ********************************
  * I. Filter Creation Tests     *
  ********************************
 */
 
+// Test cases for filter listing and finding
+TEST_F(FilterTest, Filter_list_all_names_Empty) {
+    std::vector<std::string> names = VCL::filter_list_all_names();
+    EXPECT_TRUE(names.empty()) << "Expected no filters initially, but found " << names.size();
+}
+
+TEST_F(FilterTest, Filter_list_all_names_MultipleFilters) {
+    filter_name_counter = 0;
+
+    filter_names.emplace_back("TestCacheFilterMedium_" + std::to_string(filter_name_counter++));
+    filter_names.emplace_back("TestCacheFilterMedium_" + std::to_string(filter_name_counter++));
+    filter_names.emplace_back("TestCacheFilterMedium_" + std::to_string(filter_name_counter++));
+
+    VCL::FilterParameters p0 = params_cache_medium;
+    p0.name = filter_names[0].c_str();
+    VCL::Filter* filter0 = VCL::filter_create(&p0);
+
+    VCL::FilterParameters p1 = params_cache_medium;
+    p1.name = filter_names[1].c_str();
+    VCL::Filter* filter1 = VCL::filter_create(&p1);
+
+    VCL::FilterParameters p2 = params_cache_medium;
+    p2.name = filter_names[2].c_str();
+    VCL::Filter* filter2 = VCL::filter_create(&p2);
+
+    ASSERT_NE(filter0, nullptr);
+    ASSERT_NE(filter1, nullptr);
+    ASSERT_NE(filter2, nullptr);
+
+    std::vector<std::string> names = VCL::filter_list_all_names();
+    EXPECT_EQ(names.size(), 3) << "Expected 3 filters, but found " << names.size();
+
+    std::vector<std::string> expected_names;
+    expected_names.push_back(p0.name);
+    expected_names.push_back(p1.name);
+    expected_names.push_back(p2.name);
+
+    std::sort(names.begin(), names.end());
+    std::sort(expected_names.begin(), expected_names.end());
+
+    // Compare the sorted lists
+    for (size_t i = 0; i < expected_names.size(); ++i) {
+        EXPECT_EQ(names[i], expected_names[i])
+            << "Mismatch at index " << i << ". Expected: " << expected_names[i] << ", Actual: " << names[i];
+    }
+}
+
+TEST_F(FilterTest, Filter_list_all_names_AfterFree) {
+    VCL::FilterParameters p1 = params_ht_small;
+    filter_names.emplace_back("TestHTFilterSmall_" + std::to_string(filter_name_counter++));
+    p1.name = filter_names.back().c_str();
+    VCL::Filter* filter1 = VCL::filter_create(&p1);
+
+    VCL::FilterParameters p2 = params_cache_medium;
+    filter_names.emplace_back("TestCacheFilterMedium_" + std::to_string(filter_name_counter++));
+    p2.name = filter_names.back().c_str();
+    VCL::Filter* filter2 = VCL::filter_create(&p2);
+
+    ASSERT_NE(filter1, nullptr);
+    ASSERT_NE(filter2, nullptr);
+
+    std::vector<std::string> names_before_free = VCL::filter_list_all_names();
+    EXPECT_EQ(names_before_free.size(), 2);
+
+    VCL::filter_free(filter1); // Free filter1
+
+    std::vector<std::string> names_after_free_1 = VCL::filter_list_all_names();
+    EXPECT_EQ(names_after_free_1.size(), 1);
+    EXPECT_EQ(names_after_free_1[0], p2.name); // Only p2.name should remain
+
+    VCL::filter_free(filter2); // Free filter2
+
+    std::vector<std::string> names_after_free_2 = VCL::filter_list_all_names();
+    EXPECT_TRUE(names_after_free_2.empty());
+
+}
+
+TEST_F(FilterTest, Filter_find_existing_Success) {
+    VCL::FilterParameters p1 = params_ht_small;
+    filter_names.emplace_back("TestHTFilterSmall_" + std::to_string(filter_name_counter++));
+    p1.name = filter_names.back().c_str();
+    VCL::Filter* filter1 = VCL::filter_create(&p1);
+    ASSERT_NE(filter1, nullptr);
+
+    VCL::Filter* found_filter = VCL::filter_find_existing(p1.name);
+    ASSERT_NE(found_filter, nullptr);
+    EXPECT_EQ(found_filter, filter1);
+    EXPECT_STREQ(found_filter->get_name(), p1.name);
+
+    // Test a different filter type
+    VCL::FilterParameters p2 = params_cache_medium;
+    filter_names.emplace_back("TestCacheFilterMedium_" + std::to_string(filter_name_counter++));
+    p2.name = filter_names.back().c_str();
+    VCL::Filter* filter2 = VCL::filter_create(&p2);
+    ASSERT_NE(filter2, nullptr);
+    VCL::Filter* found_filter2 = VCL::filter_find_existing(p2.name);
+    ASSERT_NE(found_filter2, nullptr);
+    EXPECT_EQ(found_filter2, filter2);
+}
+
+TEST_F(FilterTest, Filter_find_existing_NotFound) {
+    // No filters created yet (or existing ones cleared by SetUp)
+    std::string non_existent_name = "NonExistentFilter_" + std::to_string(filter_name_counter++);
+    VCL::Filter* found_filter = VCL::filter_find_existing(non_existent_name.c_str());
+    EXPECT_EQ(found_filter, nullptr);
+
+    // Create one filter, then search for a different non-existent one
+    VCL::FilterParameters p_temp = params_ht_small;
+    filter_names.emplace_back("TempFilter_" + std::to_string(filter_name_counter++));
+    p_temp.name = filter_names.back().c_str();
+    VCL::filter_create(&p_temp);
+
+    std::string another_non_existent_name = "AnotherNonExistentFilter_" + std::to_string(filter_name_counter++);
+    found_filter = VCL::filter_find_existing(another_non_existent_name.c_str());
+    EXPECT_EQ(found_filter, nullptr);
+}
+
+TEST_F(FilterTest, Filter_find_existing_NullName) {
+    VCL::Filter* found_filter = VCL::filter_find_existing(nullptr);
+    EXPECT_EQ(found_filter, nullptr);
+}
+
+
+TEST_F(FilterTest, Filter_GetName) {
+    VCL::Filter* ht_filter = VCL::filter_create(&params_ht_small);
+    ASSERT_NE(ht_filter, nullptr);
+    ASSERT_TRUE(ht_filter->is_valid());
+    EXPECT_STREQ(ht_filter->get_name(), params_ht_small.name);
+    VCL::filter_free(ht_filter); // Clean up explicitly
+
+}
+
+
 TEST_F(FilterTest, CuckooHTFilter_Creation_Success) {
     std::unique_ptr<VCL::CuckooHTFilter> filter;
     ASSERT_NO_THROW(filter = std::make_unique<VCL::CuckooHTFilter>(params_ht_small));