182 erroneous read only on server start (#308)

* Update ImageTransactionRollback test and include new test FindImageEmptyDB

This test runs a query with 2 FindImage commands on a new/empty PMGD db instance
and validates the response contains the excepted message `"No entities found"`.

Signed-off-by: Steven Rojas <[email protected]>

* Update QueryNode and QueryEdge protobuf construct handler read mode to avoid internal PMGD validation check exception

A read-write validation check is performed internally by PMGD. When running a query node/edge
transaction with a readOnly flag a validation check will trigger an exception.
The exception message will be propagated to the query response.

This change allows the validation to pass while technically the transaction is still a readOnly operation.
The validation occurs in the PMGD codebase, updating it is not reasonable at this time.

Signed-off-by: Steven Rojas <[email protected]>

* Restore previous test changes

Signed-off-by: Steven Rojas <[email protected]>

---------

Signed-off-by: Steven Rojas <[email protected]>

Author: StevenRojasC

src/PMGDQuery.cc

@@ -676,6 +676,8 @@ void PMGDQuery::QueryNode(int ref, const std::string &tag,
                           const Json::Value &constraints,
                           const Json::Value &results, bool unique,
                           bool intermediate_query) {
+  _readonly = false;
+
   PMGDCmd *cmdquery = new PMGDCmd();
   cmdquery->set_cmd_id(PMGDCmd::QueryNode);
   cmdquery->set_cmd_grp_id(_current_group_id);
@@ -713,6 +715,8 @@ void PMGDQuery::QueryEdge(int ref, int src_ref, int dest_ref,
                           const std::string &tag,
                           const Json::Value &constraints,
                           const Json::Value &results, bool unique) {
+  _readonly = false;
+
   PMGDCmd *cmdquery = new PMGDCmd();
   cmdquery->set_cmd_id(PMGDCmd::QueryEdge);
   cmdquery->set_cmd_grp_id(_current_group_id);

tests/unit_tests/RemoteConnection_test.cc

@@ -650,3 +650,58 @@ TEST_F(RemoteConnectionTest, ImageTransactionRollback) {
     printErrorMessage("ImageTransactionRollback");
   }
 }
+
+TEST_F(RemoteConnectionTest, FindImageEmptyDB) {
+  try {
+    VDMS::Server VDMS_server("unit_tests/config-aws-tests.json", "", "", "");
+
+    QueryHandlerPMGD query_handler;
+    query_handler.reset_autodelete_init_flag(); // set flag to show autodelete queue has
+                                                // been initialized
+
+    VDMS::protobufs::queryMessage proto_query;
+    VDMS::protobufs::queryMessage response;
+
+    Json::Reader json_reader;
+    Json::Value json_response;
+
+    std::string string_query_image_lookup("[");
+    string_query_image_lookup += " \
+          { \
+              \"FindImage\": { \
+                  \"results\": { \
+                      \"list\": [\"name\"] \
+                  }, \
+                  \"constraints\": { \
+                      \"name\": [ \"==\", \"NonExistentImage1\" ] \
+                  } \
+              } \
+          }, \
+          { \
+              \"FindImage\": { \
+                  \"results\": { \
+                      \"list\": [\"name\"] \
+                  }, \
+                  \"constraints\": { \
+                      \"name\": [ \"==\", \"NonExistentImage2\" ] \
+                  } \
+              } \
+          } \
+      ";
+    string_query_image_lookup += "]";
+
+    proto_query.clear_blobs();
+    proto_query.set_json(string_query_image_lookup);
+
+    query_handler.process_query(proto_query, response);
+    json_reader.parse(response.json(), json_response);
+
+    EXPECT_EQ(json_response[0]["FindImage"]["status"].asString(), "0");
+    EXPECT_EQ(json_response[0]["FindImage"]["info"], "No entities found");
+    EXPECT_EQ(json_response[1]["FindImage"]["status"].asString(), "0");
+    EXPECT_EQ(json_response[1]["FindImage"]["info"], "No entities found");
+
+  } catch (...) {
+    printErrorMessage("FindImageEmptyDB");
+  }
+}