Skip to content

S3 Connection Logging: Copy-Paste errors #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ifadams opened this issue Jul 24, 2024 · 0 comments · Fixed by #290
Closed

S3 Connection Logging: Copy-Paste errors #193

ifadams opened this issue Jul 24, 2024 · 0 comments · Fixed by #290
Labels
Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited
Milestone

Comments

@ifadams
Copy link
Contributor

ifadams commented Jul 24, 2024

Describe the bug
Very minor bug, but noting that the errors the get logged to STDERR are occasionally copy-paste and slightly misleading, e.g. a connection error for a read reporting as WRITE error redirected to cerr.

For example, in RemoteConnection.cc, this is a read/retrieval operation, but we are logging a WRITE error to STDERR.

void RemoteConnection::RetrieveFile(const std::string &filename) {
  if (_remote_connected) {
    retrieve_file(filename);
  } else {
    std::cerr << "WRITE: The RemoteConnection has not been started"
              << std::endl;
  }

Expected behavior

Error prefixes should reflect the approximate source of the error location.

@ifadams ifadams added Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited labels Jul 24, 2024
@cwlacewe cwlacewe added this to the v2.12.0 Tasks milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants