Add error for hwmc response len 0 + replace hard-coded addresses #285
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling and code maintainability for the RealSense D4xx kernel driver by adding validation for zero-length HWMC responses and replacing hard-coded register addresses with predefined constants.
- Adds error checking for zero-length HWMC responses with appropriate error logging
- Replaces hard-coded register addresses (0x4900, 0x4904, 0x4908, 0x490c) with named constants
- Adds explanatory comments for register operations
| if (ret) | ||
| return -EBADMSG; | ||
|
|
||
| if (tmp_len > cmdDataLen) | ||
| return -ENOBUFS; | ||
|
|
||
| if (tmp_len == 0) { | ||
| dev_err(&state->client->dev, |
There was a problem hiding this comment.
The comment on line 1827 contains a typo: "ccompletion" should be "completion".
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I think this is a mistake... I don't see this work
kernel/realsense/d4xx.c
Outdated
| "%s(): HWMC response length is 0, ret: %d\n", | ||
| __func__, ret); |
There was a problem hiding this comment.
The error message includes 'ret: %d' but 'ret' is always 0 at this point since the regmap_raw_read succeeded. This could be confusing as it will always log 'ret: 0' even when there's an error condition.
| "%s(): HWMC response length is 0, ret: %d\n", | |
| __func__, ret); | |
| "%s(): HWMC response length is 0\n", | |
| __func__); |
Copilot uses AI. Check for mistakes.
kernel/realsense/d4xx.c
Outdated
| "%s(): HWMC response length is 0, ret: %d\n", | ||
| __func__, ret); |
| if (ret) | ||
| return -EBADMSG; | ||
|
|
||
| if (tmp_len > cmdDataLen) | ||
| return -ENOBUFS; | ||
|
|
||
| if (tmp_len == 0) { | ||
| dev_err(&state->client->dev, |
There was a problem hiding this comment.
I think this is a mistake... I don't see this work
No description provided.