Make #clipboard in height brush work again (#3098)

IntellectualSites · Feb 14, 2025 · 7bcc9aa · 7bcc9aa
1 parent dac62f1
commit 7bcc9aa
Showing 1 changed file with 14 additions and 18 deletions.
diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/command/BrushCommands.java b/worldedit-core/src/main/java/com/sk89q/worldedit/command/BrushCommands.java
@@ -532,7 +532,7 @@ public void stencilBrush(
         int maxY = player.getWorld().getMaxY();
         try {
             brush = new StencilBrush(stream, rotation, yscale, onlyWhite,
-                    "#clipboard".equalsIgnoreCase(image)
+                    isClipboard(image)
                             ? session.getClipboard().getClipboard() : null, minY, maxY
             );
         } catch (EmptyClipboardException ignored) {
@@ -903,32 +903,28 @@ private void terrainBrush(
         int minY = player.getWorld().getMinY();
         int maxY = player.getWorld().getMaxY();
         if (flat) {
-            try {
-                brush = new FlattenBrush(stream, rotation, yscale, layers, smooth,
-                        "#clipboard".equalsIgnoreCase(image)
-                                ? session.getClipboard().getClipboard() : null, shape, minY, maxY
-                );
-            } catch (EmptyClipboardException ignored) {
-                brush = new FlattenBrush(stream, rotation, yscale, layers, smooth, null, shape, minY, maxY);
-            }
+            brush = new FlattenBrush(stream, rotation, yscale, layers, smooth,
+                    isClipboard(image)
+                            ? session.getClipboard().getClipboard() : null, shape, minY, maxY
+            );
         } else {
-            try {
-                brush = new HeightBrush(stream, rotation, yscale, layers, smooth,
-                        "#clipboard".equalsIgnoreCase(image)
-                                ? session.getClipboard().getClipboard() : null, minY, maxY
-                );
-            } catch (EmptyClipboardException ignored) {
-                brush = new HeightBrush(stream, rotation, yscale, layers, smooth, null, minY, maxY);
-            }
+            brush = new HeightBrush(stream, rotation, yscale, layers, smooth,
+                    isClipboard(image)
+                            ? session.getClipboard().getClipboard() : null, minY, maxY
+            );
         }
         if (randomRotate) {
             brush.setRandomRotate(true);
         }
         set(context, brush, "worldedit.brush.height").setSize(radius);
     }
 
+    private static boolean isClipboard(String image) {
+        return "#clipboard".equalsIgnoreCase(image);
+    }
+
     private InputStream getHeightmapStream(String filename) throws FileNotFoundException {
-        if (filename == null || "none".equalsIgnoreCase(filename)) {
+        if (filename == null || "none".equalsIgnoreCase(filename) || isClipboard(filename)) {
             return null;
         }
         String filenamePng = filename.endsWith(".png") ? filename : filename + ".png";