Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating schematics creates messed up results #2741

Open
2 tasks done
MineFact opened this issue May 21, 2024 · 2 comments
Open
2 tasks done

Rotating schematics creates messed up results #2741

MineFact opened this issue May 21, 2024 · 2 comments
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working

Comments

@MineFact
Copy link
Contributor

Server Implementation

Paper

Server Version

1.20.5/6

Describe the bug

Whenever you rotate schematics with a different angle than the standard 90, 180, 270, 360 degrees, the result is completely messed creating weird shapes.
I know that WorldEdit doesn't recommend to use other angles than 90 but with normal WorldEdit rotation works mostly fine with just a few missing blocks at certain angles here and there. FastAsyncWorldEdit completely messes up the shapes though creating a result that is impossible to work with.

Here I pasted a sample lantern schematic so you can better see the issues that appear with FastAsyncWorldEdit at anything other than 90 degrees even 45.
With WorldEdit everything works as expected no matter which version you choose from 1.12 till latest version.

WorldEdit Result (everything fine):
2024-05-17_15 25 23

FastAsyncWorldEdit (messed up):
2024-05-17_15 34 58

Here you can see that any angle other than the 90s create unexpected results. Sometimes the lamp stand appears twice, sometimes the entire lamp is cut off. Its also weird that there doesn't seem to be a clear pattern in this behavior.
The lamp was copied at the bottom of the lamp stand so the rotation should be alright as visible in the WorldEdit screenshot.

To Reproduce

  1. Load a schematic with //schem load streetlamp (Get sample streetlamp schematic here)
  2. Rotate the schematic with //rotate 45
  3. Paste the schematic with //paste

Expected behaviour

When pasting the schematic the result should look similar to WorldEdit and not messed up.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/8e010b08548142cd9e61cf3a4873d7d8

Fawe Version

FastAsyncWorldEdit version 2.10.1-SNAPSHOT-776;3dc949e

Checklist

Anything else?

No response

@MineFact MineFact added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label May 21, 2024
@PierreSchwang PierreSchwang added Bug Something isn't working Approved Added if an issue has been approved by a maintainer and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels May 26, 2024
@PierreSchwang
Copy link
Member

It's not that easy for me to reproduce, but I kinda get it

I had to rotate some obscure radii quite often, which resulted in sometimes the sea lantern not being pasted:

[17:04:32 INFO]: PierreV2 issued server command: //schem load streetlamp.schem
[17:04:37 INFO]: PierreV2 issued server command: //paste
[17:04:43 INFO]: PierreV2 issued server command: //rotate 45
[17:04:44 INFO]: PierreV2 issued server command: //paste
[17:04:48 INFO]: PierreV2 issued server command: //rotate 90
[17:04:50 INFO]: PierreV2 issued server command: //paste
[17:04:58 INFO]: PierreV2 issued server command: //rotate 87
[17:04:59 INFO]: PierreV2 issued server command: //paste
[17:05:08 INFO]: PierreV2 issued server command: //rotate 20
[17:05:09 INFO]: PierreV2 issued server command: //paste

@Hasenzahn1
Copy link

Tested with FAWE-Bukkit-2.11.2-SNAPSHOT-895 and the result is still not optimal.
image

Created using the above sample schematic.
Always rotated by 20, 25, 25, 20 degrees for a quarter of a circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants