Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands using Selections now require Confirm label #3077

Open
2 tasks done
Zeranny opened this issue Jan 13, 2025 · 1 comment
Open
2 tasks done

Commands using Selections now require Confirm label #3077

Zeranny opened this issue Jan 13, 2025 · 1 comment
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@Zeranny
Copy link
Contributor

Zeranny commented Jan 13, 2025

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

Changes in #3052 now require commands using selections to include @Confirm(Confirm.Processor.REGION). Not having this gives a pretty unfriendly error:

image

Previously you would just get the regular informative error:

image

I have tested adding the annotation to one command and it doesn't appear to cause issues with regular WorldEdit, so the change doesn't cause any compatibility issues.

To Reproduce

  1. Create a command which takes a Selection
  2. Do not add the Confirm annotation
  3. Run the command ingame without an active selection
  4. IllegalStateException error

Expected behaviour

Commands expecting a selection which do not recieve one should error instructively as before:
image

Effectively, when no @Confirm(...) is present for the region, Confirm.Processor.REGION should be the default.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d8e209464d4e4bcd85aec7766117481f

Fawe Version

FastAsyncWorldEdit-Bukkit-2.12.4-SNAPSHOT-1020

Checklist

Anything else?

No response

@Zeranny Zeranny added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jan 13, 2025
@Zeranny Zeranny changed the title API Commands using Selections now require Confirm label Commands using Selections now require Confirm label Jan 21, 2025
@Zeranny
Copy link
Contributor Author

Zeranny commented Jan 21, 2025

@eztaK-red correctly pointed out that the command manager isn't technically part of the API and is internal.

I have removed reference to this being an API issue, so this is more of a request than a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

No branches or pull requests

1 participant