Skip to content

fix(ui): Added loading spinner #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

abansal15
Copy link
Contributor

Description

This update improves the user experience by ensuring graphs load smoothly and provides a loading indicator while data is being fetched.

Related issue

#914

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dpgiakatos dpgiakatos self-requested a review February 23, 2025 07:10
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has broken the functionality of the Metis page. Now the graphs are not displaying. See the expected behavior in the following link:
https://www.ihr.live/en/metis/deployment

@abansal15
Copy link
Contributor Author

abansal15 commented Feb 27, 2025

Screen.Recording.2025-02-27.091236.mp4

@dpgiakatos can you please review it and see the video i have shown it by reducing net speed so that spineer can be shown and sorry for late reply actually mid sem exams were going on that why..

@dpgiakatos dpgiakatos self-requested a review February 27, 2025 04:03
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dpgiakatos dpgiakatos merged commit 162b37b into InternetHealthReport:master Feb 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants