Skip to content

Fix: topology chart deletion #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Salah-Tamer
Copy link
Contributor

Description

Fixed an issue in the Network Topology view where deleting the second empty chart would cause the entire layout to collapse. The bug was caused by inconsistent handling of empty arrays in the route query parameters.

The fix ensures that route query parameters (input and af) are always maintained in the route, regardless of whether the charts are empty or not. This creates consistent behavior when managing empty charts and keeps the layout stable during deletion operations.

Implementation details:

  • Modified the (pushRoute) function to always maintain query parameters
  • Simplified the route update logic for more consistent behavior

Related issue

#948

How Has This Been Tested?

  1. Created multiple empty charts (2 and 4) to verify consistent behavior
  2. Deleted charts in different orders to ensure layout stability
  3. Verified route query parameters are maintained correctly
  4. Tested layout preservation with empty charts
  5. Verified that both (input and af) parameters remain in the route

Screenshots:

Here's a video for clarification:

Fix.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dpgiakatos dpgiakatos merged commit a8868e8 into InternetHealthReport:master Mar 26, 2025
4 of 6 checks passed
@Salah-Tamer Salah-Tamer deleted the bug/948/topology-chart-deletion branch March 26, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants