-
Notifications
You must be signed in to change notification settings - Fork 19
Refactor and modernise DRep
golden tests for thread-safety
#1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor and modernise DRep
golden tests for thread-safety
#1209
Conversation
@@ -121,26 +123,25 @@ hprop_golden_governance_drep_id_hex = | |||
|
|||
-- | Execute me with: | |||
-- @cabal test cardano-cli-golden --test-options '-p "/golden governance drep id hash/"'@ | |||
hprop_golden_governance_drep_id_hash :: Property | |||
hprop_golden_governance_drep_id_hash = | |||
watchdogProp . propertyOnce $ do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep watchdogs everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to write a new watchdog for the new test api. I wanted to see it hang in one of these property test first before adding it.
8baf41b
to
8d3138d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this refactor is necessary. Let's explore other options.
This PR is stale because it has been open 45 days with no activity. |
Changelog
Context
This PR improves the structure and exception safety of golden tests related to
DRep
governance features by:UnitIO
style enabled byHedgehog.Extras.Test.New.Monad
fromhedgehog-extras
, which simplifies composition and improves readability.serveFilesWhile
to two new modules:Test.Cardano.CLI.Network
(used in traditional test code)Test.Cardano.CLI.New.Network
(uses MonadMask, preferred in the new-style tests)Dependency Update
Updates the
hedgehog-extras
dependency, for the new support for theUnitIO
abstraction and new test monads.Benefits
UnitIO
.MonadMask
.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist