-
Notifications
You must be signed in to change notification settings - Fork 19
Switch to use UnitIO
in golden tests
#1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
da551e9
to
ce42acc
Compare
2141242
to
8b88b41
Compare
8b88b41
to
fc63509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why watchdog is removed?
I'm interesting in seeing if it is need in CI by allowing it to run there for a few runs. If it still happens, we can integrate the watchdog into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an an explanation as to why we are using UnitIO
in the description.
fc63509
to
041af4e
Compare
More information has been added to the Context section. |
041af4e
to
156b070
Compare
156b070
to
57e7e6c
Compare
2a4e4c4
to
90eb5eb
Compare
Changelog
Context
UnitIO
makes it clear that the test is a unit test and not a property test so there can be no confusion what kind of test it is.The monad also adds type safety by not allow generators to be accidentally used as these should be reserved for property tests.
The setup for
UnitIO
tests is also slightly easier.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist