Skip to content

Upgrade to hedgehog-extras-0.8.0.0 for partial fix to hanging issue #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 24, 2025

Changelog

- description: |
    Upgrade to `hedgehog-extras-0.8.0.0` for partial fix to hanging issue
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This upgrade should reduce the hanging frequency to reduce reliance of watchdogProp, but watchdogProp is retained because there are still hangs in some other cases.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review June 24, 2025 15:14
where
cfg = H.WatchdogConfig{H.watchdogTimeout = 20}
watchdogProp :: H.Property -> H.Property
watchdogProp = id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this do nothing because moduleWorkspace is fixed to not hang in the newest version of hedgehog-extras.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove it altoghether?

Copy link
Contributor Author

@newhoggy newhoggy Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to see if succeed in CI first with minimal changes.

I'll make a subsequent PR to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Hydra CI triggered the hang still which was the case I was worried about.

@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch from 7802f57 to dbbc8d3 Compare June 25, 2025 06:09
@carbolymer
Copy link
Contributor

  1. The PR type should be test and not compatible.
  2. You need to sign your commits

@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch from dbbc8d3 to 54a5e9d Compare June 25, 2025 12:17
@newhoggy newhoggy added this pull request to the merge queue Jun 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 26, 2025
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimbo4350 spotted timeout in merge queue. Seems that it's not fixing the issue. We still need watchdogs.
https://github.com/IntersectMBO/cardano-cli/runs/44861297938

@carbolymer carbolymer mentioned this pull request Jun 26, 2025
3 tasks
@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch from 54a5e9d to 3ddc87c Compare June 27, 2025 07:02
@newhoggy newhoggy changed the title Fix hanging issue. Make watchdogProp do nothing Upgrade to hedgehog-extras-0.8.0.0 for partial fix to hanging issue Jun 27, 2025
@newhoggy newhoggy dismissed carbolymer’s stale review June 27, 2025 07:04

Removed disabling of watchdogProp.

@newhoggy newhoggy requested a review from carbolymer June 27, 2025 07:04
@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch from 3ddc87c to 300b351 Compare June 27, 2025 09:46
@newhoggy newhoggy requested review from a team as code owners June 27, 2025 09:46
@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch 2 times, most recently from d3e938e to 7f8ef2d Compare June 28, 2025 09:44
@newhoggy newhoggy force-pushed the newhoggy/fix-hanging-issue branch from 7f8ef2d to e9797f2 Compare June 28, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants