-
Notifications
You must be signed in to change notification settings - Fork 19
Upgrade to hedgehog-extras-0.8.0.0
for partial fix to hanging issue
#1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
where | ||
cfg = H.WatchdogConfig{H.watchdogTimeout = 20} | ||
watchdogProp :: H.Property -> H.Property | ||
watchdogProp = id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this do nothing because moduleWorkspace
is fixed to not hang in the newest version of hedgehog-extras
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove it altoghether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to see if succeed in CI first with minimal changes.
I'll make a subsequent PR to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Hydra CI triggered the hang still which was the case I was worried about.
7802f57
to
dbbc8d3
Compare
|
dbbc8d3
to
54a5e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jimbo4350 spotted timeout in merge queue. Seems that it's not fixing the issue. We still need watchdogs.
https://github.com/IntersectMBO/cardano-cli/runs/44861297938
54a5e9d
to
3ddc87c
Compare
watchdogProp
do nothinghedgehog-extras-0.8.0.0
for partial fix to hanging issue
3ddc87c
to
300b351
Compare
d3e938e
to
7f8ef2d
Compare
7f8ef2d
to
e9797f2
Compare
Changelog
Context
This upgrade should reduce the hanging frequency to reduce reliance of
watchdogProp
, butwatchdogProp
is retained because there are still hangs in some other cases.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist