Skip to content

Use everything under Hedgehog.Extras.Test from hedgehog-extras via module Test.Cardano.CLI.Hedgehog #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 29, 2025

Changelog

- description: |
    Use everything under `Hedgehog.Extras.Test` from `hedgehog-extras` via module `Test.Cardano.CLI.Hedgehog`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Having all the tests Test.Cardano.CLI.Hedgehog instead of hedgehog-extras directly means some functions can be replaced with local versions which can aid in the testing of different versions of the local version before they are upstreamed to hedgehog-extras.

This means we can iterate quickly on debugging the hanging problem by substituting our own version of moduleWorkspace runWatchdog and similar functions.

Doing it this way saves us from having to release hedgehog-extras without being sure the problem is solved just so that it can be tested in CI.

Once we are sure the hanging problem is resolved we can upstream the fixes and if we wish rollback the introduction of this module.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behaviour, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review June 29, 2025 06:56
@newhoggy newhoggy force-pushed the newhoggy/new-module-Test.Cardano.CLI.Hedgehog branch from 220d54b to d711321 Compare June 30, 2025 15:00
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit here?

@newhoggy newhoggy requested a review from carbolymer July 1, 2025 11:04
@newhoggy newhoggy force-pushed the newhoggy/new-module-Test.Cardano.CLI.Hedgehog branch from d711321 to 478da22 Compare July 1, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants