-
Notifications
You must be signed in to change notification settings - Fork 19
Local error golden test functions #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
-Wno-x-partial | ||
-Wno-name-shadowing | ||
-Wno-incomplete-uni-patterns | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Would be nice to have a comment explaining why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the Windows builds fails otherwise. The asn1-encoding
package fails to build because it generates warnings on Windows and our build errors out on warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added.
4d6d095
to
987346b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you moving the functions here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question as @Jimbo4350 . Why vendor in functions here, rather than fixing them upstream?
I'm not convinced this PR is a net benefit because I haven't seen hangups in golden tests in cardano-api
and we are using those functions there as well.
@newhoggy Have you seen hangups in error messages' goldens? Have you seen them in cardano-api as well?
The reason I want this is there are unexplained hangs and if watchdogProp can catch it I can log which test it is and there was one hang where this test was the last test that ran. If The PR is not meant to be permanent. When the root cause of the hangs are determined, this can be rolled back and any changes upstreamed. |
987346b
to
efdd3f1
Compare
efdd3f1
to
0d1f9c8
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist