Move protocol parameters update code #1250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/move-protocol-parameters-update
branch
from
8586356 to
bd65454
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ShelleyBasedEraBabbage -> | ||
| shelleyToBabbageProtocolParametersUpdate sbe eraBasedPParams' | ||
| ShelleyBasedEraConway -> conwayProtocolParametersUpdate sbe eraBasedPParams' | ||
| where |
Check notice
Code scanning / HLint
Redundant where Note
Comment on lines
703
to
707
| [ (,mSwit) | ||
| <$> ( fmap (Exp.convertToNewCertificate Exp.useEra) $ | ||
| fromEitherIOCli $ | ||
| readFileTextEnvelope (File certFile) | ||
| ) |
Check notice
Code scanning / HLint
Move brackets to avoid $ Note
Jimbo4350
force-pushed
the
jordan/move-protocol-parameters-update
branch
from
bd65454 to
0d19b55
Compare
Jimbo4350
requested review from
a team,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/move-protocol-parameters-update
branch
2 times, most recently
from
4e0a38f to
240df0c
Compare
`Cardano.CLI.Compatible.Governance.Types`
The compatible protocol parameter update command is compatible for all eras whilst the (poorly named) "era based" protocol parameter command is now parameterized on `Era era`
…CompatibleGovernanceActionCreateProtocolParametersUpdateCmd`Factor out relevant eons
Jimbo4350
force-pushed
the
jordan/move-protocol-parameters-update
branch
from
240df0c to
30a9b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist