Skip to content

Add query for the max major protocol version #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amesgen opened this issue Apr 22, 2025 · 0 comments
Open

Add query for the max major protocol version #1477

amesgen opened this issue Apr 22, 2025 · 0 comments

Comments

@amesgen
Copy link
Member

amesgen commented Apr 22, 2025

IntersectMBO/cardano-cli#773 motivates a query to obtain the maximum major protocol version supported by one's node. The goal of this ticket is to add such a query.

It is part of the (partial) ConsensusConfig, e.g. for Praos:

-- | All blocks invalid after this protocol version, see
-- 'Globals.maxMajorPV'.
praosMaxMajorPV :: !MaxMajorProtVer,

There are at least two ways to accomplish this:

  • Add a Shelley BlockQuery constructor to get just the MaxMajorProtVer.

    Most direct and least amount of work, but ad-hoc.

  • Add a GetConsensusConfig query, similar to GetLedgerConfig as added in Add new GetLedgerConfig query #1394.

    Potentially more principled and avoiding additional ad-hoc queries for part of the ConsensusConfig, but more work, and maybe YAGNI.

    EDIT: Probably shouldn't go with this option: Downgrade GetLedgerConfig to a debug query #1478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant