Skip to content

Enriched Genesis tests to confirm all Genesis components are disabled when GSM transitions to CaughtUp #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfrisby opened this issue Apr 30, 2025 · 0 comments
Labels
better-tests Ideas to improve the tests

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Apr 30, 2025

Today's test suite doesn't test this, and so didn't catch Issue #1490. It's straight-forward enough that I'm surprised code review didn't catch it. Regardless, it's tech debt to not cover that with tests.

Moreover: for GDD, LoP, LoE, etc the logic for disabling and re-enabling is trivial, but for CSJ the re-enable logic might not be trivial. There is at least one trivial option, but it's somewhat wasteful. So some tests should exercise this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-tests Ideas to improve the tests
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants