You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today's test suite doesn't test this, and so didn't catch Issue #1490. It's straight-forward enough that I'm surprised code review didn't catch it. Regardless, it's tech debt to not cover that with tests.
Moreover: for GDD, LoP, LoE, etc the logic for disabling and re-enabling is trivial, but for CSJ the re-enable logic might not be trivial. There is at least one trivial option, but it's somewhat wasteful. So some tests should exercise this.
The text was updated successfully, but these errors were encountered:
Today's test suite doesn't test this, and so didn't catch Issue #1490. It's straight-forward enough that I'm surprised code review didn't catch it. Regardless, it's tech debt to not cover that with tests.
Moreover: for GDD, LoP, LoE, etc the logic for disabling and re-enabling is trivial, but for CSJ the re-enable logic might not be trivial. There is at least one trivial option, but it's somewhat wasteful. So some tests should exercise this.
The text was updated successfully, but these errors were encountered: