Skip to content

Remove Cardano-specific TxMeasure dimensions from abstract Consensus layer #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amesgen opened this issue May 26, 2025 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@amesgen
Copy link
Member

amesgen commented May 26, 2025

#1191 introduced an ad-hoc type class to the abstract Consensus layer

class TxMeasureMetrics msr where
txMeasureMetricTxSizeBytes :: msr -> ByteSize32
txMeasureMetricExUnitsMemory :: msr -> Natural
txMeasureMetricExUnitsSteps :: msr -> Natural
txMeasureMetricRefScriptsSizeBytes :: msr -> ByteSize32

that is required by LedgerSupportsMempool blk. It is used only for the LocalTxMonitor server implementation.

The goal of this ticket is to remove this Cardano-specific notion from the abstract Consensus layer again, eg by changing the class to sth like

class TxMeasureMetrics msr where 
  txMeasureMetricTxSizeBytes :: msr -> Map MeasureName Natural
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant