Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Drupal utility scripts #260

Open
nigelgbanks opened this issue Nov 1, 2022 · 0 comments
Open

Deprecate Drupal utility scripts #260

nigelgbanks opened this issue Nov 1, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@nigelgbanks
Copy link
Contributor

We should be pushing for images that are by and large configured at build time or in the worst case by confd templates, and should not rely on running commands via docker exec. As it is unreliable and less predictable and requires a release of isle-buildkit for downstream consumers.

To that end:

  • An audit should be done of all the scripts
  • A deprecate notice should be raised (not sure how to do this as they are bash scripts, but it should go into the release notes at least).
  • Update the documentation to describe a better method for applying configuration from environment variables (i.e. how sandbox does it).
  • On a subsequent release, the scripts can then be removed.

For example:
https://github.com/Islandora-Devops/isle-buildkit/blob/d5e177dc50acf964925f59684b6988f25a2620e2/drupal/rootfs/etc/islandora/utilities.sh

Has many assumptions about modules configuration etc, and is used to mutate settings.php at run time.

Those scripts were born out of porting what Ansible did into Docker, a good first start, but it's time to move on from them.

@nigelgbanks nigelgbanks self-assigned this Nov 1, 2022
@nigelgbanks nigelgbanks added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant