Merge pull request #104 from IsmaelMartinez/develop

IsmaelMartinez · web-flow · commit 2c1c19546a89 · 2019-04-12T14:53:32.000+01:00
0.2.0
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,82 @@
+# Contributing
+
+First of all, thanks for thinking about contributing. Hopefully the following guidelines will help you contributing. If you got any questions, do add a issue with your questions and we will try to help.
+
+## Development
+
+This is a fairly small project. IMO, the ideal size for getting started with electron.
+
+Just fork the repo and dive in. The app/index.js is the starting of all the application.
+
+Once changes are made, just do a pull request to develop.
+
+Each subfolder has a README.md file that explains the reason of existence and any extra required information.
+
+## Pre-requisites
+
+To run this application from source, you will need yarn installed.
+
+Please refer to the [yarn installation page](https://yarnpkg.com/en/docs/install)
+
+## Run from source
+
+To run the application from source:
+
+```bash
+yarn start
+```
+
+## Build for linux
+
+We are using [electron-build](https://www.electron.build/) in conbination with [travis-ci](https://travis-ci.org/) to create our build files.
+
+If you want to generate the build locally, you can run the following command:
+
+```bash
+yarn run dist:linux
+```
+
+This will build an deb, rpm, snap, AppImage and tar.gz files in the dist folder. This files can be run in most popular linux distributions.
+
+### Snap build
+
+Is possible to specify the snap or AppImage build type using running this:
+
+```bash
+# Standalone build
+yarn run dist:linux:snap
+
+# Or, if you have docker installed, you can alternatively build there
+./dockerBuildSnap.sh
+```
+
+This will build the snap into the `dist/` directory.
+
+#### Install using locally built snap file
+
+To install the snap file using the generated file use this command.
+
+```bash
+cd dist
+sudo snap install teams-for-linux_VERSION_amd64.snap --dangerous
+```
+
+#### Install using snap from store
+
+```bash
+sudo snap install teams-for-linux
+```
+
+#### Use camera using the Snap build
+
+Snap uses confinement to provide more security, this restric the access to hardware or data on your device to prevent security issues.
+
+The camera is a restricted device on Snap, so you need to allow the access to the camera on Teams For Linux to be able to do videocalls, to do that run this command after the installation of the snap to create an interface to the camera:
+
+```bash
+sudo snap connect teams-for-linux:camera core:camera
+```
+
+## Version number
+
+We are following SemVer at the moment. The lower number in master will be increased after a release (basically, to avoid re-releasing stuff with some changes), but release number will be decided just before a release trying to use SemVer standards.
diff --git a/HISTORY.md b/HISTORY.md
@@ -0,0 +1,15 @@
+# History
+
+This branch was a child fork of [JamieMagee teams-for-linux](https://github.com/JamieMagee/teams-for-linux) repo, that was itself a fork of [Ivelkov teams-for-linux](https://github.com/ivelkov/teams-for-linux).
+
+Jamie did express his desire to refactor this project in Typescript and to support it, but he has archive the project and I suspect that means he doesn't have the time to support it.
+
+I have tried to contact Ivelkov for a few months but haven't receive any answers.
+
+For that reason, decided to refork it and fix a few things that where not working. The list has grown since then to support many features and to fix most of the bugs.
+
+To be able to use a few github functionalities, it was decided to unfork the project #87.
+
+Ideally this project will die when Microsoft implements a desktop client for linux. Please do vote for it in the [Microsoft Suggestions Forum](https://microsoftteams.uservoice.com/forums/555103-public/suggestions/16911565-linux-client)
+
+Currently, the project is in a stable condition, and should continue as long as needed. Non stable versions are released as pre-release.
diff --git a/KNOWN_ISSUES.md b/KNOWN_ISSUES.md
@@ -0,0 +1,40 @@
+# Known issues
+
+## Oauth services
+
+Some services requires the app to open the windows in electron. An example is github that requires authentication using oauth.
+
+We are defaulting in opening the links in a external browser, but links can be open ina electron windows by using the 'Crl+Click' combination.
+
+## No history
+
+Switching the userAgent with the persistence turn on sometimes have the side effect of "loosing" the channels history. Removing the data under `~/.config/teams-for-linux` or, if using snap `rm -rf /home/$HOME/snap/teams*`, should fix the issue.
+
+## Spellchecker not working
+
+Details are in issue [#28](https://github.com/IsmaelMartinez/teams-for-linux/issues/28)
+
+In short, node_spellchecker only ships with en_US dictionary.
+
+As a work around, only valid when running from source, you can enable the use of local dictionaries by following the next steps:
+
+1. Install hunspell and your locale dictionary as indicates in this link [https://github.com/atom/spell-check#debian-ubuntu-and-mint](https://github.com/atom/spell-check#debian-ubuntu-and-mint)
+2. Run the following commands from the root of the app (where this README.md file is located)
+  1.`mv node_modules/spellchecker/vendor/hunspell_dictionaries node_modules/spellchecker/vendor/hunspell_dictionaries.old` mv the en_US dictionaries to another location.
+  2.`ln -s /usr/share/hunspell/ node_modules/spellchecker/vendor/hunspell_dictionaries` create a simbolic link to the hunspell dictionaries. Note, I am using the default location for hunspell.
+
+Starting the app with `yarn start`, and if you have your system configured with the right dictionaries and locale, you should be able to see the spellchecker working.
+
+Unfortunately, at this moment in time it is not possible to use local dictionaries with the packaged app. Fixing issue [51](https://github.com/atom/node-spellchecker/issues/51) in node-spellchecker should solve this issue.
+
+## Strange link icon on snap app
+
+Some snap installation show a non standard icon for links. If you suffer this, please use the deb package instead.
+
+Please refer to the issue #99 for more info.
+
+## No desktop notifications
+
+Some notifications daemons in linux don't support the implementation that Microsoft implemented in the browser.
+
+This project includes a desktop notification hack that can be enable by running the application with `teams-for-linux --enableDesktopNotificationsHack`.
diff --git a/README.md b/README.md
@@ -2,137 +2,28 @@
 
 ![](https://img.shields.io/github/release/IsmaelMartinez/teams-for-linux.svg?style=flat)
 ![](https://img.shields.io/github/downloads/IsmaelMartinez/teams-for-linux/total.svg?style=flat)
-
-
-[![Build Status](https://travis-ci.org/IsmaelMartinez/teams-for-linux.svg?branch=master)](https://travis-ci.org/IsmaelMartinez/teams-for-linux) 
-[![dependencies Status](https://david-dm.org/IsmaelMartinez/teams-for-linux/status.svg)](https://david-dm.org/IsmaelMartinez/teams-for-linux) 
+[![Build Status](https://travis-ci.org/IsmaelMartinez/teams-for-linux.svg?branch=develop)](https://travis-ci.org/IsmaelMartinez/teams-for-linux)
+[![dependencies Status](https://david-dm.org/IsmaelMartinez/teams-for-linux/status.svg)](https://david-dm.org/IsmaelMartinez/teams-for-linux)
 [![devDependencies Status](https://david-dm.org/IsmaelMartinez/teams-for-linux/dev-status.svg)](https://david-dm.org/IsmaelMartinez/teams-for-linux?type=dev)
 
 Unofficial Microsoft Teams client for Linux using [Electron](https://electronjs.org/).
 It uses the Web App and wraps it as a standalone application using Electron.
 
-## Install
-
-You can download the tarball, rpm or deb from the [releases page](https://github.com/IsmaelMartinez/teams-for-linux/releases).
-
-## Run from source
-
-```bash
-yarn start
-```
-
-## Build for linux
-
-```bash
-yarn run dist:linux
-```
-
-This will build an deb, rpm, snap, AppImage and tar.gz files in the dist folder. This files can be run in most popular linux distributions.
-
-Is possible to specify the snap or AppImage build type using running this:
-
-```bash
-# Standalone build
-yarn run dist:linux:snap
-
-# Or, if you have docker installed, you can alternatively build there
-./dockerBuildSnap.sh
-```
-
-This will build the snap into the `dist/` directory.
-
-### Install using locally built snap file
-
-To install the snap file using the generated file use this command.
-
-```bash
-cd dist
-sudo snap install teams-for-linux_VERSION_amd64.snap --dangerous
-```
-
-### Install using snap from store
-
-
-```bash
-sudo snap install teams-for-linux
-```
-
-#### Use camera using the Snap build
-
-Snap uses confinement to provide more security, this restric the access to hardware or data on your device to prevent security issues.
-
-The camera is a restricted device on Snap, so you need to allow the access to the camera on Teams For Linux to be able to do videocalls, to do that run this command after the installation of the snap to create an interface to the camera:
-
-```bash
-sudo snap connect teams-for-linux:camera core:camera
-```
-
 ## Available starting arguments
 
 Check in the config [README.md](app/config/README.md) in the config folder.
 
-## Development
-
-This is a fairly small project. IMO, the ideal size for getting started with electron.
+## Contributing
 
-Just fork the repo and dive in. The app/index.js is the starting of all the application.
-
-Once changes are made, just do a pull request to master.
-
-Each subfolder has a README.md file that explains the reason of existence and any extra required information.
-
-### Version number
-
-We are following SemVer at the moment. The lower number in master will be increased after a release (basically, to avoid re-releasing stuff with some changes), but release number will be decided just before a release trying to use SemVer standards. 
+Please refer to the [CONTRIBUTING.md](CONTRIBUTING.md) file for more information about how to run this application from source, and/or how to contribute.
 
 ## History
 
-This branch is a child fork of [JamieMagee teams-for-linux](https://github.com/JamieMagee/teams-for-linux) repo, that is itself a fork of [Ivelkov teams-for-linux](https://github.com/ivelkov/teams-for-linux).
-
-Jamie did express his desire to refactor this project in Typescript and to support it, but he has archive the project and I suspect that means he doesn't have the time to support it. 
-
-I have tried to contact Ivelkov for a few months but haven't receive any answers.
-
-For that reason, decided to refork it and fix a few things that where not working. The list has grown since then to support many features and to fix most of the bugs.
-
-Ideally this project will die when Microsoft implements a desktop client for linux. Please do vote for it in the [Microsoft Suggestions Forum](https://microsoftteams.uservoice.com/forums/555103-public/suggestions/16911565-linux-client)
-
-Currently, the project is in a stable condition, and should continue as long as needed. Non stable versions are released as pre-release.
+Read about the history about this project in the [HISTORY.md](HISTORY.md) file.
 
 ## Known issues
 
-### Oauth services
-
-Some services requires the app to open the windows in electron. An example is github that requires authentication using oauth.
-
-We are defaulting in opening the links in a external browser, but links can be open ina electron windows by using the 'Crl+Click' combination.
-
-### No history
-
-Switching the userAgent with the persistence turn on sometimes have the side effect of "loosing" the channels history. Removing the data under `~/.config/teams-for-linux` or, if using snap `rm -rf /home/$HOME/snap/teams*`, should fix the issue.
-
-### Spellchecker not working
-
-Details are in issue [#28](https://github.com/IsmaelMartinez/teams-for-linux/issues/28)
-
-In short, node_spellchecker only ships with en_US dictionary.
-
-As a work around, only valid when running from source, you can enable the use of local dictionaries by following the next steps:
-
-1. Install hunspell and your locale dictionary as indicates in this link [https://github.com/atom/spell-check#debian-ubuntu-and-mint](https://github.com/atom/spell-check#debian-ubuntu-and-mint)
-2. Run the following commands from the root of the app (where this README.md file is located)
-  1.`mv node_modules/spellchecker/vendor/hunspell_dictionaries node_modules/spellchecker/vendor/hunspell_dictionaries.old` mv the en_US dictionaries to another location.
-  2.`ln -s /usr/share/hunspell/ node_modules/spellchecker/vendor/hunspell_dictionaries` create a simbolic link to the hunspell dictionaries. Note, I am using the default location for hunspell.
-
-Starting the app with `yarn start`, and if you have your system configured with the right dictionaries and locale, you should be able to see the spellchecker working.
-
-Unfortunately, at this moment in time it is not possible to use local dictionaries with the packaged app. Fixing issue [51](https://github.com/atom/node-spellchecker/issues/51) in node-spellchecker should solve this issue.
-
-### No desktop notifications
-
-Some notifications daemons in linux don't support the implementation that Microsoft implemented in the browser.
-
-This project includes a desktop notification hack that can be enable by running the application with `teams-for-linux --enableDesktopNotificationsHack`.
+Known issues and workarounds can be found in the [KNOWN_ISSUES.md](KNOWN_ISSUES.md) file.
 
 ## License
 
diff --git a/app/browser/index.js b/app/browser/index.js
@@ -51,6 +51,10 @@
 		injector.get('settingsService').appConfig.enableScreenSharingToolbar = true;
 		injector.get('settingsService').appConfig.enableCallingScreenPreviewLabel = true;
 		injector.get('settingsService').appConfig.callingEnableChromeOneToOneVideo = true;
+		injector.get('settingsService').appConfig.enableMeetingStartedNotificationWeb = true;
+		injector.get('settingsService').appConfig.enableMicOSUnmuteOnUnmute = true;
+		injector.get('settingsService').appConfig.enableModeratorsSupport = true;
+		injector.get('settingsService').appConfig.enableRecordPPTSharing = true;
 	}
 
 	function disablePromoteStuff(injector) {
diff --git a/app/config/README.md b/app/config/README.md
@@ -12,6 +12,7 @@ Here is the list of available arguments and its usage:
 |:-:|:-:|:-:|
 | help  | show the available commands | false |
 | version | show the version number | false |
+| onlineOfflineReload | Reload page when going from offline to online | true |
 | disableDesktopNotificationsHack | disable electron-desktop-notifications extension hack | false |
 | closeAppOnCross | Close the app when clicking the close (X) cross | false |
 | partition | [BrowserWindow](https://electronjs.org/docs/api/browser-window) webpreferences partition | persist:teams-4-linux |
@@ -37,24 +38,27 @@ Alternatively, you can use a file called `config.json` with the configuration op
 
 ## Getting custom CA Certs fingerprints
 
-The expected fingerprints are of the form `sha256/<md5 encoded sha256sum>`. Tools like openssl usually deliver the sha256sum
+The expected fingerprints are of the form `sha256/<base64 encoded sha256sum>`. Tools like openssl usually deliver the sha256sum
  encoded in hexadecimal format. If you have access to the nodejs console, the fingerprint of the CA that cannot be validated
  will be printed out. You can then start teams-for-linux again with
+
 ```bash
 teams-for-linux --customCACertsFingerprints sha256//L/iiGIG9ysnWTyLBwKX4S12ntEO15MHBagJjv/BTRc= [--customCACertsFingerprints otherfingerprint]`
 ```
 
 If you already have the certificate in a file locally, you can calculate the expected fingerprint with the following command:
+
 ```bash
 echo sha256/$(openssl x509 -in /path/to/certificate -noout -fingerprint -sha256 | sed -e "s/^.*=//g" -e "s/://g" | xxd -r -p | base64)
 ```
 
 To have your custom certs recognized on every run, add them to your `~/.config/teams-for-linux/config.json`
+
 ```json
 {
-	"customCACertsFingerprints": [
-		"sha256//L/iiGIG9ysnWTyLBwKX4S12ntEO15MHBagJjv/BTRc=",
-		"sha256/QNUEPU40JDSrRcW9CSWsPKJ5llVjGcc1AnsIkCF9KV4="
-	]
+    "customCACertsFingerprints": [
+        "sha256//L/iiGIG9ysnWTyLBwKX4S12ntEO15MHBagJjv/BTRc=",
+        "sha256/QNUEPU40JDSrRcW9CSWsPKJ5llVjGcc1AnsIkCF9KV4="
+    ]
 }
-```
+```
diff --git a/app/config/index.js b/app/config/index.js
@@ -12,6 +12,11 @@ function argv(configPath) {
 				describe: 'Close the app when clicking the close (X) cross',
 				type: 'boolean',
 			},
+			onlineOfflineReload: {
+				default: true,
+				describe: 'Reload page when going from offline to online',
+				type: 'boolean',
+			},
 			enableDesktopNotificationsHack: {
 				default: false,
 				describe: 'Enable electron-native-notifications hack',
diff --git a/app/index.js b/app/index.js
@@ -51,8 +51,10 @@ if (!gotTheLock) {
 		});
 
 		login.handleLoginDialogTry(window);
-		onlineOffline.reloadPageWhenOfflineToOnline(window, config.url);
-
+		if (config.onlineOfflineReload) {
+			onlineOffline.reloadPageWhenOfflineToOnline(window, config.url);
+		}
+		
 		window.webContents.setUserAgent(config.chromeUserAgent);
 
 		window.once('ready-to-show', () => window.show());
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "teams-for-linux",
-  "version": "0.1.18",
+  "version": "0.2.0",
   "main": "app/index.js",
   "description": "Unofficial client for Microsoft Teams for Linux",
   "homepage": "https://github.com/IsmaelMartinez/teams-for-linux",
@@ -59,7 +59,9 @@
         "AppImage",
         "pacman"
       ],
-      "mimeTypes": ["application/sip"],
+      "mimeTypes": [
+        "application/sip"
+      ],
       "publish": {
         "provider": "github",
         "releaseType": "draft"
diff --git a/yarn.lock b/yarn.lock
