Add depends for geos-gcm-env #1658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Jun 4, 2025
|
|
||
| # Current version | ||
| version("1.0.0") | ||
| version("1.1.0") |
There was a problem hiding this comment.
We've been really lazy with these versions. Most *-env packages in our custom spack repo still have 1.0.0, except a few (e.g. NEPTUNE). It's really up to you, but I would align the version with the version of GEOS this environment supports.
There was a problem hiding this comment.
Ooh. So that goes up to like v11.7 or something. Okay. I'll try and figure out the right version to use.
climbfuji
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a few new dependencies for the
geos-gcm-env:I also removed @danholdaway as a maintainer, since, well, he's not really doing that anymore, but I did add @Dooruk just as a back up. (Maybe in the future it can change.)
Note: I also advanced the version but, well, I'm not sure I should be? I'll let @climbfuji let me know if I should have.
Testing
I've been trying to build a spack stack at NAS and found that when I did my
ml geos-gcm-envmy cmake for GEOSgcm failed because, well, no udunits. I then checked myApplications affected
I think just GEOSgcm. SWELL has its own metamodule.
Systems affected
I guess...all of them? It's not machine dependent.
Dependencies
None
Issue(s) addressed
Closes #1657
Checklist