Skip to content

Commit d45fba7

Browse files
committed
minor edits in some plotting functions
1 parent 8c7cd24 commit d45fba7

5 files changed

+12
-12
lines changed

R/plot_FRmatch_cell2cluster.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#' @param return.value Boolean variable indicating if to return the plotted values. Default: \code{FALSE}.
1616
#' @param filename,width,height Plotting parameters passed to \code{\link[ggplot2]{ggsave}}.
1717
#'
18-
#' @return If \code{return.value = TRUE}, a matrix of \code{plotted.values}, and a data frame of \code{cell2cluster} with adjusted score.
18+
#' @return If \code{return.value = TRUE}, a matrix of \code{plotted.values}, and \code{pmat.adj} and \code{cell2cluster.adj} after adjustment.
1919
#'
2020
#' @export
2121

@@ -66,7 +66,7 @@ plot_FRmatch_cell2cluster <- function(rst.cell2cluster, type="match.prop", p.adj
6666

6767
## output
6868
if(return.value){
69-
return(list("plotted.values"=tab.match.prop, "cell2cluster"=rst.cell2cluster$cell2cluster))
69+
return(list("plotted.values"=tab.match.prop, "pmat.adj"=pmat.adj, "cell2cluster.adj"=rst.cell2cluster$cell2cluster))
7070
}
7171
}
7272

R/plot_cluster_by_markers.R

+7-7
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#' @param sce.E1,sce.E2 Data objects of the \link[SingleCellExperiment]{SingleCellExperiment} data class. If only \code{sce.E1},
77
#' then the "barcode" is a self plot, i.e. both cluster (\code{cluster.name}) and marker genes are from the same experiment.
88
#' If both \code{sce.E1} and \code{sce.E2} are provided, then the "barcode" is a cross-experiment plot, i.e. marker genes are from
9-
#' \code{sce.E1} (reference) andcluster (\code{cluster.name}) is from \code{sce.E2} (query).
9+
#' \code{sce.E1} (reference) and cluster (\code{cluster.name}) is from \code{sce.E2} (query).
1010
#' @param cluster.name Name of the cluster to be plotted.
1111
#' @param nsamp Number of randomly selected cells to plot for a large cluster. Default: \code{30}.
1212
#' @param name.E1,name.E2 Prefix names for E1 and E2. Default: \code{"E1."} and \code{"E2."}, respectively.
@@ -28,7 +28,7 @@ plot_cluster_by_markers <- function(sce.E1, sce.E2=NULL, cluster.name, nsamp=30,
2828
stop(paste(cluster.name, "is not found in the plotting data object. \n"))}
2929

3030
## reference marker genes
31-
markergenes <- rownames(sce.ref)[rowData(sce.ref)$marker_gene==1]
31+
markergenes <- unique(sce.ref@metadata$cluster_marker_info$markerGene) #marker genes in ORDER!!!
3232
## cells of query cluster
3333
col.query <- colData(sce.query)$cluster_membership==cluster.name
3434

@@ -41,6 +41,7 @@ plot_cluster_by_markers <- function(sce.E1, sce.E2=NULL, cluster.name, nsamp=30,
4141
mat.query <- assay(sce.query[,col.query]) %>% as.data.frame() %>% rownames_to_column() %>%
4242
right_join(as.data.frame(markergenes, stringsAsFactors=FALSE), by=c("rowname"="markergenes")) %>%
4343
column_to_rownames() %>% as.matrix()
44+
mat.query <- mat.query[markergenes,]
4445
}
4546

4647
## randomly select nsamp number of cells
@@ -49,10 +50,10 @@ plot_cluster_by_markers <- function(sce.E1, sce.E2=NULL, cluster.name, nsamp=30,
4950
### self plot ###
5051
if(is.null(sce.E2)){
5152
## main
52-
if(is.null(main)) main <- paste0(name.E1,cluster.name)
53+
if(is.null(main)) main <- paste0(name.E1, cluster.name)
5354
## indicator for markers
5455
if(!is.null(sce.query@metadata$cluster_marker_info)){
55-
mat.query <- mat.query[unique(sce.query@metadata$cluster_marker_info$markerGene),]
56+
# mat.query <- mat.query[unique(sce.query@metadata$cluster_marker_info$markerGene),]
5657
temp <- rep(0, nrow(mat.query))
5758
markers.i <- sce.query@metadata$cluster_marker_info %>% filter(clusterName==cluster.name) %>% pull(markerGene)
5859
temp[rownames(mat.query) %in% markers.i] <- 1
@@ -86,13 +87,12 @@ plot_cluster_by_markers <- function(sce.E1, sce.E2=NULL, cluster.name, nsamp=30,
8687
if(is.null(main)) main <- paste0(name.E2,cluster.name)
8788
## plot
8889
pheatmap(mat.query,
89-
color = viridis::inferno(10), border_color = NA,
90+
color = inferno(10), border_color = NA,
9091
cluster_rows = FALSE, cluster_cols = FALSE,
9192
cellheight = cellheight, cellwidth = cellwidth,
9293
show_rownames = TRUE, show_colnames = FALSE,
9394
labels_col = "Cells", angle_col = "0",
94-
main=main,
95-
filename=filename,
95+
main=main, filename=filename,
9696
...)
9797
}
9898
}

man/FRmatch.Rd

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/plot_FRmatch_cell2cluster.Rd

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/plot_cluster_by_markers.Rd

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)