Skip to content

Wrong positioning of indicator if origin of image frame is non zero #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonsleptsov opened this issue Dec 23, 2015 · 4 comments
Labels

Comments

@antonsleptsov
Copy link

looks like property "center" is taken relatively to parent view. It causes shifting of indicator. Please change

activityIndicator.center = self.center

to

CGRect frame = self.frame;
activityIndicator.center = CGPointMake(frame.size.width / 2, frame.size.height / 2);

That will be correct positioning

@AnthonyMDev
Copy link
Collaborator

@antonsleptsov Thanks for catching this. Would you be able to make a PR for this that @JRG-Developer or I can review and pull in?

@antonsleptsov
Copy link
Author

Please make update by yourself. Thanks in advance.

@JRG-Developer
Copy link
Owner

I've moved to using Alamofire instead of AFNetworking for my networking needs.

Consequently, this means I'm not focusing on this library so much...

As @AnthonyMDev mentions, you can submit your own pull request, and either Anthony or I will be happy to take a look.

Don't have time? I don't either.

Sorry, but this is open-source software, which means it's low priority when times get busy, and times are really busy for me.

If this is something you care about immediately, @AnthonyMDev, feel free to put something together, and I'd be happy to review it, provide advice, whatever you need. :-]

If not, then meh?

@AnthonyMDev
Copy link
Collaborator

@JRG-Developer I'm not using this anymore either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants