Skip to content

Commit 3c285e7

Browse files
committed
Resolve Checkstyle errors
1 parent 8f1f017 commit 3c285e7

File tree

2 files changed

+22
-7
lines changed

2 files changed

+22
-7
lines changed

src/main/java/org/jabref/cli/ArgumentProcessor.java

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@
3939
import org.jabref.logic.importer.SearchBasedFetcher;
4040
import org.jabref.logic.importer.WebFetchers;
4141
import org.jabref.logic.importer.fileformat.BibtexParser;
42+
import org.jabref.logic.journals.JournalAbbreviationLoader;
4243
import org.jabref.logic.journals.JournalAbbreviationRepository;
44+
import org.jabref.logic.journals.JournalAbbreviationValidator;
4345
import org.jabref.logic.l10n.Localization;
4446
import org.jabref.logic.net.URLDownload;
4547
import org.jabref.logic.os.OS;
@@ -870,15 +872,24 @@ public List<UiCommand> getUiCommands() {
870872
}
871873

872874
private void validateJournalAbbreviations() {
873-
JournalAbbreviationRepository repository = JournalAbbreviationLoader.loadRepository(preferences.getJournalAbbreviationPreferences());
874-
List<ValidationResult> issues = repository.getValidationIssues();
875-
875+
JournalAbbreviationRepository repository = loadJournalAbbreviationRepository();
876+
List<JournalAbbreviationValidator.ValidationResult> issues = repository.getValidationIssues();
877+
printValidationResults(issues);
878+
}
879+
880+
private JournalAbbreviationRepository loadJournalAbbreviationRepository() {
881+
return JournalAbbreviationLoader.loadRepository(cliPreferences.getJournalAbbreviationPreferences());
882+
}
883+
884+
private void printValidationResults(List<JournalAbbreviationValidator.ValidationResult> issues) {
876885
if (issues.isEmpty()) {
877-
System.out.println(Localization.lang("No validation issues found in journal abbreviations."));
886+
System.out.println(Localization.lang("No validation issues found in journal abbreviations"));
878887
} else {
879-
System.out.println(Localization.lang("Found %0 validation issues:", issues.size()));
880-
for (ValidationResult issue : issues) {
881-
System.out.println(Localization.lang("Type: %0, Message: %1", issue.getType(), issue.getMessage()));
888+
System.out.println(Localization.lang("Found %0 validation issues", issues.size()));
889+
for (JournalAbbreviationValidator.ValidationResult issue : issues) {
890+
System.out.println(Localization.lang("Type: %0, Message: %1",
891+
issue.getType().name(),
892+
issue.getMessage()));
882893
}
883894
}
884895
}

src/main/java/org/jabref/cli/CliOptions.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,10 @@ public boolean isJumpToKey() {
192192
return commandLine.hasOption("jumpToKey");
193193
}
194194

195+
public boolean isValidateJournals() {
196+
return commandLine.hasOption("validate-journals");
197+
}
198+
195199
public Optional<String> getValidateJournals() {
196200
return Optional.ofNullable(commandLine.getOptionValue("validate-journals"));
197201
}

0 commit comments

Comments
 (0)