Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable irrelevant context menu options for unsaved libraries #11920

Open
LoayGhreeb opened this issue Oct 11, 2024 · 14 comments
Open

Disable irrelevant context menu options for unsaved libraries #11920

LoayGhreeb opened this issue Oct 11, 2024 · 14 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@LoayGhreeb
Copy link
Collaborator

  1. Create a new library.
  2. The "Reveal in file explorer" and "Open terminal here" options should be disabled, as the library is not yet saved to disk.

Image

@LoayGhreeb LoayGhreeb added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 11, 2024
@LoayGhreeb LoayGhreeb changed the title Disable irrelevant context menu options for unsaved libraries #602 Disable irrelevant context menu options for unsaved libraries Oct 11, 2024
@vaifai
Copy link

vaifai commented Oct 11, 2024

Hey, I am new and would like to make an attempt and contribute to this issue. Additionally, I would appreciate it if you could provide some guidance on where I should begin.

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 11, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@ThiloteE ThiloteE added the ui label Oct 12, 2024
@vaifai
Copy link

vaifai commented Oct 13, 2024

Starting out to work on this.

@koppor
Copy link
Member

koppor commented Oct 14, 2024

See #11941 for an inspiration how this could work. Note that the conditions are differently in this case.

@koppor koppor added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Oct 16, 2024
@vaifai
Copy link

vaifai commented Oct 22, 2024

Hi @koppor , while trying to setup my environment, I was facing a certain issue. I followed exactly the steps mentioned in the local workspace setup section.

Your build is currently configured to use Java 21.0.4 and Gradle 8.10.2.

Possible solution:
 - Use Java 19 as Gradle JVM: Open Gradle settings 
 - Open Gradle wrapper settings, change `distributionUrl` property to use compatible Gradle version and reload the project```

I did research about some of the potential ways about how can I resolve this but couldn't fix it. Also, the build is successful but the run isn't.

@koppor
Copy link
Member

koppor commented Oct 23, 2024

while trying to setup my environment, I was facing a certain issue. I followed exactly the steps mentioned in the local workspace setup section.

The guide is pretty long and I do not know at wich step you are facing this issue.

I think, you did not paste the line "Unspported Java".

Somewhere in your IntelliJ, another Java version is configured. Could you try: https://stackoverflow.com/a/76574494/873282. Maybe also https://stackoverflow.com/a/75782695/873282.

@kjswaruph
Copy link

@koppor can i take up this issue, if the issue isnt resolved

@koppor
Copy link
Member

koppor commented Nov 7, 2024

@vaifai Are you going to finish the issue?

@koppor
Copy link
Member

koppor commented Nov 7, 2024

/unassign @vaifai

Copy link
Contributor

github-actions bot commented Nov 7, 2024

👋 Hey @vaifai, you've been automatically unassigned from this issue due to inactivity.

Note

If you'd like to be re-assigned, just leave another comment or ask a maintainer to assign you again.
If you're still actively working on the issue, let us know by commenting, and we can pin it to prevent automatic unassignment.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Nov 7, 2024
@koppor
Copy link
Member

koppor commented Nov 7, 2024

/assign @kjswaruph

Copy link
Contributor

github-actions bot commented Nov 7, 2024

👋 Hey @kjswaruph, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 30 days (by 07 December 2024). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Nov 7, 2024
@kjswaruph
Copy link

kjswaruph commented Nov 7, 2024

@koppor the issue is fixed should i create pr
i read all the guidelines and commited my changes can you please check before i create my pr

@koppor
Copy link
Member

koppor commented Nov 7, 2024

@kjswaruph There are multiple persons available for reviewing. Please submit a pull request. All other ways create much effort for us - and this is still a free time project for us...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Assigned
Status: Assigned
Status: Normal priority
Development

No branches or pull requests

6 participants