Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not on fx thread on cleanup with undo redo binding #11974

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix not on fx thread on cleanup with undo redo binding #11974

merged 1 commit into from
Oct 16, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 15, 2024 •
edited
Loading

Fixes #11966

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11974/merge.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 67d6062 Oct 16, 2024
32 checks passed
@Siedlerchr Siedlerchr deleted the fixCleanup branch October 16, 2024 05:16
@github-actions GitHub Actions
Copy link
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
@Siedlerchr @ExrosZ-Alt
fix not on fx thread (JabRef#11974)
f79614d 
Fixes JabRef#11966
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
@Siedlerchr @ExrosZ-Alt
fix not on fx thread (JabRef#11974)
5ba141c 
Fixes JabRef#11966
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 21, 2024
@Siedlerchr @ExrosZ-Alt
fix not on fx thread (JabRef#11974)
d9a6b56 
Fixes JabRef#11966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use "Cleanup Entries" on more than one entry
2 participants
@Siedlerchr @koppor