Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import at "Find Unlinked Files" should not re-add an identical entry #551

Open
koppor opened this issue Dec 23, 2021 · 9 comments · May be fixed by JabRef/jabref#12076
Open

Import at "Find Unlinked Files" should not re-add an identical entry #551

koppor opened this issue Dec 23, 2021 · 9 comments · May be fixed by JabRef/jabref#12076

Comments

@koppor
Copy link
Owner

koppor commented Dec 23, 2021

When clicking twice on Import, the entry is imported twice. This should not happen; identical entries should be reimported

grafik

@cdiegobb
Copy link

Hi it´s possible to know how enter in this options thanks

@koppor
Copy link
Owner Author

koppor commented Sep 26, 2023

@cdiegobb If I understand your question right, you are asking how to start that functionality? It changed now and then in the past. Currently, it is reachable from "Lookup":

image

@koppor koppor changed the title Import at "Find Unlinked Files" should ne readd an identical entry Import at "Find Unlinked Files" should not re-add an identical entry Sep 26, 2023
@cdiegobb
Copy link

cdiegobb commented Oct 3, 2023

@koppor Yes thanks i will try to work on that

@koppor
Copy link
Owner Author

koppor commented Oct 6, 2023

@cdiegobb Thank you! Please try to do test-driven development. I hope, you are knowledable with JUnit.

@ThiloteE
Copy link
Collaborator

@cdiegobb, since there has not been any activity, I assume you have dropped the issue. Be aware you can unassign yourself from Github.
image

@R-Zhou4
Copy link

R-Zhou4 commented Oct 9, 2024

Hi, is this issue still available to take? I am looking for an issue as my first contribution. I'd like to work on this issue.

@ThiloteE
Copy link
Collaborator

ThiloteE commented Oct 9, 2024

As a general advice for newcomers: check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@R-Zhou4
Copy link

R-Zhou4 commented Oct 16, 2024

Hello, I would like to ask if I should create a branch to solve the issue or fork the main branch. According to the contribution documentation, it mentions creating a branch to work on the issue, but I don't have permission to create a new branch in the repository. Could you please clarify the correct approach? Thanks

@koppor
Copy link
Owner Author

koppor commented Oct 16, 2024

@R-Zhou4 Thank you for the question. I refined our guide at JabRef#11978.

image

The hint is to follow the "Pre Condition 3: Code on the local machine". Maybe, we should be more clear in this step and change the heading? - Currently, I hope that the text "a) create a fork" should make clear that this is required to contribute.

I hope, the text provided at this page guides you well.

R-Zhou4 pushed a commit to R-Zhou4/jabref that referenced this issue Oct 19, 2024
R-Zhou4 pushed a commit to R-Zhou4/jabref that referenced this issue Oct 24, 2024
R-Zhou4 pushed a commit to R-Zhou4/jabref that referenced this issue Oct 24, 2024
R-Zhou4 added a commit to R-Zhou4/jabref that referenced this issue Oct 24, 2024
R-Zhou4 pushed a commit to R-Zhou4/jabref that referenced this issue Oct 25, 2024
R-Zhou4 pushed a commit to R-Zhou4/jabref that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants