clipping issue

[dactest]

Is there a way to fix this, also zoom in and out max-min limit?

[JakkuSakura]

Hi, could you explain a bit about what's the clipping issue?

I can see there are some overlapping between different klines, but not sure it's what you mean.
There are also some overlapping to the left of the plot. Maybe they are issues from the kline implementation?

[dactest]

right, those overlapping btw candles and with the right & left side of the plot. so you mean its the issue with plotters-rs not with our backend?

[JakkuSakura]

Our backend only plots based on pixels and handles events & integration with gpui framework. It has a high chance that issues are from the plotters-rs. Clipping and figure layout is handled by plotters. I have seen similar issues with ECharts-js. Can have a deeper check when I have time

[JakkuSakura]

Could you share me the code to reproduce?

[dactest]

I just took the candlestick example from plotter_gpui and tried to see the pan and zoom and it started overlapping at the edges.
you can use the same data. if you cant reproduce it i can share the sample.

[JakkuSakura]

I see. will have a look soon

[JakkuSakura]

It's been fixed now. just the zooming has some precision loss

[dactest]

The screenshot you have shared also overlaps on the edges. also can we add limit to zoom-in out levels?

[JakkuSakura]

The situation is different now.
The big overlaps on the graph edges are fixed

But the small overlaps on candlebar edges are not.
Both issues are from plotters, not this repo or plotters-gpui's bug.
I'll have a look what I can do.

[JakkuSakura]

This is a common issue in plotting libs. I see it also in echarts apache/echarts#18675
plotly handles this correctly though. https://plotly.com/python/candlestick-charts/

[JakkuSakura]

plotters-rs/plotters#686
plotters-rs/plotters#685