PHP8.5 compatibility

#477

Author: JamesHeinrich

getid3/getid3.php

@@ -387,7 +387,7 @@ class getID3
 	 */
 	protected $startup_warning = '';
 
-	const VERSION           = '1.9.24-202512160912';
+	const VERSION           = '1.9.24-202512161137';
 	const FREAD_BUFFER_SIZE = 32768;
 
 	const ATTACHMENTS_NONE   = false;

getid3/module.audio-video.quicktime.php

@@ -3098,11 +3098,13 @@ public function Pascal2String($pascalstring) {
 	public function MaybePascal2String($pascalstring) {
 		// Pascal strings have 1 unsigned byte at the beginning saying how many chars (1-255) are in the string
 		// Check if string actually is in this format or written incorrectly, straight string, or null-terminated string
-		if (ord(substr($pascalstring, 0, 1)) == (strlen($pascalstring) - 1)) {
-			return substr($pascalstring, 1);
-		} elseif (substr($pascalstring, -1, 1) == "\x00") {
-			// appears to be null-terminated instead of Pascal-style
-			return substr($pascalstring, 0, -1);
+		if (strlen($pascalstring) > 0) {
+			if (ord(substr($pascalstring, 0, 1)) == (strlen($pascalstring) - 1)) {
+				return substr($pascalstring, 1);
+			} elseif (substr($pascalstring, -1, 1) == "\x00") {
+				// appears to be null-terminated instead of Pascal-style
+				return substr($pascalstring, 0, -1);
+			}
 		}
 		return $pascalstring;
 	}

getid3/module.audio.mp3.php

@@ -1178,7 +1178,7 @@ public function RecursiveFrameScanning(&$offset, &$nextframetestoffset, $ScanAsC
 
 			$nextframetestarray = array('error' => array(), 'warning' => array(), 'avdataend' => $info['avdataend'], 'avdataoffset'=>$info['avdataoffset']);
 			if ($this->decodeMPEGaudioHeader($nextframetestoffset, $nextframetestarray, false)) {
-				getid3_lib::safe_inc($info['mp3_validity_check_bitrates'][$nextframetestarray['mpeg']['audio']['bitrate']]);
+				getid3_lib::safe_inc($info['mp3_validity_check_bitrates'][intval($nextframetestarray['mpeg']['audio']['bitrate'])]);
 				if ($ScanAsCBR) {
 					// force CBR mode, used for trying to pick out invalid audio streams with valid(?) VBR headers, or VBR streams with no VBR header
 					if (!isset($nextframetestarray['mpeg']['audio']['bitrate']) || !isset($firstframetestarray['mpeg']['audio']['bitrate']) || ($nextframetestarray['mpeg']['audio']['bitrate'] != $firstframetestarray['mpeg']['audio']['bitrate'])) {