Stop calling imagedestroy in PHP8+

ZabeMath · web-flow · commit d0e221b73bde · 2026-01-21T21:20:27.000+01:00
diff --git a/getid3/module.graphic.bmp.php b/getid3/module.graphic.bmp.php
@@ -676,12 +676,16 @@ public function PlotBMP(&$BMPinfo) {
 			}
 			if (headers_sent()) {
 				echo 'plotted '.($BMPinfo['resolution_x'] * $BMPinfo['resolution_y']).' pixels in '.(time() - $starttime).' seconds<BR>';
-				imagedestroy($im);
+				if (PHP_VERSION_ID < 80000) { // imagedestroy does nothing after PHP8 and give deprecation warnings in PHP8.5
+					imagedestroy($im);
+				}
 				exit;
 			} else {
 				header('Content-type: image/png');
 				imagepng($im);
-				imagedestroy($im);
+				if (PHP_VERSION_ID < 80000) {
+					imagedestroy($im);
+				}
 				return true;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -676,12 +676,16 @@ public function PlotBMP(&$BMPinfo) {`
`676`	`676`	`}`
`677`	`677`	`if (headers_sent()) {`
`678`	`678`	`echo 'plotted '.($BMPinfo['resolution_x'] * $BMPinfo['resolution_y']).' pixels in '.(time() - $starttime).' seconds<BR>';`
`679`		`- imagedestroy($im);`
	`679`	`+ if (PHP_VERSION_ID < 80000) { // imagedestroy does nothing after PHP8 and give deprecation warnings in PHP8.5`
	`680`	`+ imagedestroy($im);`
	`681`	`+ }`
`680`	`682`	`exit;`
`681`	`683`	`} else {`
`682`	`684`	`header('Content-type: image/png');`
`683`	`685`	`imagepng($im);`
`684`		`- imagedestroy($im);`
	`686`	`+ if (PHP_VERSION_ID < 80000) {`
	`687`	`+ imagedestroy($im);`
	`688`	`+ }`
`685`	`689`	`return true;`
`686`	`690`	`}`
`687`	`691`	`}`