QT skip comment copy on empty data

JamesHeinrich · JamesHeinrich · commit edafafdf6098 · 2026-01-08T09:38:10.000-05:00
#477
diff --git a/getid3/getid3.php b/getid3/getid3.php
@@ -387,7 +387,7 @@ class getID3
 	 */
 	protected $startup_warning = '';
 
-	const VERSION           = '1.9.24-202601031735';
+	const VERSION           = '1.9.24-202601080932';
 	const FREAD_BUFFER_SIZE = 32768;
 
 	const ATTACHMENTS_NONE   = false;
diff --git a/getid3/module.audio-video.quicktime.php b/getid3/module.audio-video.quicktime.php
@@ -647,7 +647,9 @@ public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset
 							}
 						}
 					}
-					$this->CopyToAppropriateCommentsSection($atomname, $atom_structure['data'], $atom_structure['name']);
+					if (!empty($atom_structure['data'])) { // https://github.com/JamesHeinrich/getID3/issues/477#issuecomment-3723356688
+						$this->CopyToAppropriateCommentsSection($atomname, $atom_structure['data'], $atom_structure['name']);
+					}
 					break;
 
 

Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,9 @@ public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset`
`647`	`647`	`}`
`648`	`648`	`}`
`649`	`649`	`}`
`650`		`- $this->CopyToAppropriateCommentsSection($atomname, $atom_structure['data'], $atom_structure['name']);`
	`650`	`+ if (!empty($atom_structure['data'])) { // https://github.com/JamesHeinrich/getID3/issues/477#issuecomment-3723356688`
	`651`	`+ $this->CopyToAppropriateCommentsSection($atomname, $atom_structure['data'], $atom_structure['name']);`
	`652`	`+ }`
`651`	`653`	`break;`
`652`	`654`
`653`	`655`