Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe is undefined when QUnit.asyncTest() is invoked #20

Open
bobkhoda opened this issue Jul 15, 2016 · 3 comments
Open

Iframe is undefined when QUnit.asyncTest() is invoked #20

bobkhoda opened this issue Jul 15, 2016 · 3 comments

Comments

@bobkhoda
Copy link

image

This issue occurs intermittently and causes the test suite to fail.

A fix was found by checking the iframe and calling initIframe() if the iframe is undefined. A pull request with the changes will be submitted.

@JamesMGreene
Copy link
Owner

I can't really see how that's possible, unfortunately, and you haven't provided any real info here.

  • What are the steps to reproduce this? Can you provide me with a JSFiddle/JSBin/CodePen/repo/etc. that can reproduce this?
  • What version of QUnit core are you using?
  • What browsers (and versions) does this occur in?

@the-t-in-rtf
Copy link

I have the same problem with qunit-composite 1.01-1.2.2, QUnit 1.12.0, and recent versions of Firefox
on OS X (52.0.2, for example). The fix @bobkhoda suggested resolves these.

I am attempting to reproduce this in isolation using a branch of the qunit-composite repo and its tests.

@the-t-in-rtf
Copy link

I've been trying things with the qunit-composite tests themselves. I can't even get close to QUnit 1.12.0, Firefox 52.0.2 hangs unrecoverably with anything less than 1.15.0. I will use the workaround for now and report here if I can figure a way to reproduce this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants