Skip to content

Commit 4ce3e52

Browse files
committed
fix: Remove TruffleHog secret scanning
TruffleHog v3.92.5 has an incompatible AGPL-3.0 license. GitHub's built-in secret scanning already provides this functionality automatically, making the third-party action redundant.
1 parent 03e64a3 commit 4ce3e52

File tree

1 file changed

+2
-29
lines changed

1 file changed

+2
-29
lines changed

.github/workflows/codeql.yml

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -99,28 +99,9 @@ jobs:
9999
path: vulnerable-packages.txt
100100
retention-days: 30
101101

102-
secret-scanning:
103-
name: Secret Scanning
104-
runs-on: ubuntu-latest
105-
if: github.event_name == 'pull_request'
106-
107-
steps:
108-
- name: Checkout repository
109-
uses: actions/checkout@v6
110-
with:
111-
fetch-depth: 0
112-
113-
- name: TruffleHog OSS
114-
uses: trufflesecurity/trufflehog@v3.82.13
115-
with:
116-
path: ./
117-
base: ${{ github.event.repository.default_branch }}
118-
head: HEAD
119-
extra_args: --only-verified
120-
121102
security-summary:
122103
name: Security Summary
123-
needs: [analyze, dependency-scanning, secret-scanning]
104+
needs: [analyze, dependency-scanning]
124105
runs-on: ubuntu-latest
125106
if: always()
126107

@@ -129,17 +110,9 @@ jobs:
129110
run: |
130111
echo "CodeQL Analysis: ${{ needs.analyze.result }}"
131112
echo "Dependency Scanning: ${{ needs.dependency-scanning.result }}"
132-
echo "Secret Scanning: ${{ needs.secret-scanning.result }}"
133-
134-
# Secret scanning is only run on PRs, so treat skipped as success
135-
SECRET_SCAN_STATUS="${{ needs.secret-scanning.result }}"
136-
if [ "$SECRET_SCAN_STATUS" == "skipped" ]; then
137-
SECRET_SCAN_STATUS="success"
138-
fi
139113
140114
if [ "${{ needs.analyze.result }}" == "success" ] && \
141-
[ "${{ needs.dependency-scanning.result }}" == "success" ] && \
142-
[ "$SECRET_SCAN_STATUS" == "success" ]; then
115+
[ "${{ needs.dependency-scanning.result }}" == "success" ]; then
143116
echo "All security scans passed!"
144117
exit 0
145118
else

0 commit comments

Comments
 (0)