Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication in subclasses of ElkLayouter #853

Open
alexanderpann opened this issue Jun 6, 2024 · 0 comments
Open

Reduce code duplication in subclasses of ElkLayouter #853

alexanderpann opened this issue Jun 6, 2024 · 0 comments

Comments

@alexanderpann
Copy link
Collaborator

Copied from #844 (comment)

One things that we maybe can improve is to reduce the code duplication. I see that all the subclasses of ElkLayouter basically just copy all the properties for the layout algorithm. The is the LayoutMetaDataService that provides information about the available algorithms and their properties. Maybe we can make use of it and have a generic implementation. This would also have the benefit, that new properties in future version of ELK are then automatically available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant