Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional authentication flags for Docker client #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oh6hay
Copy link
Contributor

@oh6hay oh6hay commented Mar 3, 2022

Some docker registries require authentication

With authentication:

dockpin docker pin -f Dockerfile.foo -u username -p password

or

dockpin docker resolve your.private.registry/foobar:20.04 -u username -p password

@Jille
Copy link
Owner

Jille commented Mar 3, 2022

Nice, I was hoping to get to registry authentication. Would it be possible to load the credentials from the user's docker config file?

@oh6hay
Copy link
Contributor Author

oh6hay commented Mar 3, 2022

Nice, I was hoping to get to registry authentication. Would it be possible to load the credentials from the user's docker config file?

That's a good idea, I'll look into it. TIL about the config file. In case the auth string exists for the repository being contacted, I think it should be used by default, so there would be no need for the user and pass flags, what do you think?

@Jille
Copy link
Owner

Jille commented Mar 4, 2022

That'd be great indeed! Thanks!

@oh6hay
Copy link
Contributor Author

oh6hay commented Aug 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants