use to_ZZ() to convert integers>2^31 to bigint

Author: JohnCremona

libsrc/eclib/xmod.h

@@ -203,7 +203,7 @@ inline bigint xmodmul(const bigint& a, const bigint& b, const bigint& m) {return
 
 #if(1)
 const int DEFAULT_MODULUS = BIGPRIME;
-// table of inversers of residues<20 modulo BIGPRIME:
+// table of inverses of residues<20 modulo BIGPRIME:
 static int table_invs[20] = {0,1, 536870895, 357913930, 805306342, 214748358, 178956965, 920350105, 402653171, 477218573, 107374179, 97612890, 626349377, 330382089, 997045947, 71582786, 738197480, 442128972, 775480181, 226050903};
 #else
 const int DEFAULT_MODULUS = 1073741783; //BIGPRIME-6;

tests/tegros.cc

@@ -45,7 +45,7 @@ int main(void)
   cout << "Q("<<S5<<", 6) has "<<Q_S5_6.size() << " elements (should be "<<2*pow(6,S5.size())<<")\n";
   cout<<endl;
 
-  bigrational j(bigint(272223782641), bigint(164025));
+  bigrational j(to_ZZ("272223782641"), bigint(164025));
   cout<<"Curves with good reduction outside "<<S5<<" and j = "<<j;
   if (is_j_possible(j,S5))
     cout <<" do exist"<<endl;
@@ -66,7 +66,7 @@ int main(void)
   cout << "Elliptic curves with conductor a power of 11, from their known j-invariants" << endl;
   vector<bigrational> j11 = {
     bigrational(bigint(-122023936), bigint(161051)),
-    bigrational(bigint(-52893159101157376), bigint(11)),
+    bigrational(to_ZZ("-52893159101157376"), bigint(11)),
     bigrational(bigint(-4096), bigint(11)),
     bigrational(bigint(-121)),
     bigrational(bigint(-32768)),

tests/telog.cc

@@ -113,7 +113,7 @@ int main(){
   /*
   // a curve (7998K1) with rank 1 and 5-torsion:
 
-  Curve c(1,0,0,5355560,7740216896);
+  Curve c(1,0,0,5355560,to_ZZ("7740216896");
   Curvedata cd(c,1);
 
   Point P0(cd, bigint(-248),bigint(80104)) ;