Syntax highlighting improvements (#259)

* Use base syntax highlighting for normal variables

Allows constants to be coloured

* Update changelog

* some highlighting file updates

Author: JohnnyMorganz

CHANGELOG.md

@@ -47,6 +47,7 @@ local y = tbl.data -- Should give "This is some special information"
 - Luau analyze now exits with code 0 if there are no reported errors (all errors are ignored)
 - `require(instance:FindFirstChild("Testing", true))` will no longer resolve as an immediate child of instance due to the recursive argument
 - Fixed a bug where internally the wrong pointer to an Instance type was being used for DM nodes which manifested into failed unification and `never` types
+- Constant variables will now be syntax highlighted appropriately at definition site (`local CONSTANT`)
 
 ## [1.14.3] - 2022-12-10
 

editors/code/syntaxes/lua.tmLanguage.json

@@ -384,6 +384,15 @@
           "name": "punctuation.definition.interpolated-string-expression.end.lua"
         }
       },
+      "patterns": [
+        {
+          "include": "#expression"
+        }
+      ],
+      "name": "meta.template.expression.lua",
+      "contentName": "meta.embedded.line.lua"
+    },
+    "expression": {
       "patterns": [
         {
           "include": "#keywords"
@@ -406,9 +415,7 @@
         {
           "include": "#identifier"
         }
-      ],
-      "name": "meta.template.expression.lua",
-      "contentName": "meta.embedded.line.lua"
+      ]
     },
     "identifier": {
       "patterns": [
@@ -533,14 +540,10 @@
           },
           "patterns": [
             {
-              "include": "source.lua"
+              "include": "#expression"
             }
           ]
         },
-        {
-          "match": "\\b(readonly)\\b",
-          "name": "storage.modifier.readonly.lua"
-        },
         {
           "match": "\\btrue\\b",
           "name": "constant.language.boolean.true.lua"

src/operations/SemanticTokens.cpp

@@ -166,6 +166,8 @@ struct SemanticTokensVisitor : public Luau::AstVisitor
             {
                 auto followedTy = Luau::follow(*ty);
                 auto type = inferTokenType(&followedTy, lsp::SemanticTokenTypes::Variable);
+                if (type == lsp::SemanticTokenTypes::Variable)
+                    return true; // No special semantic token needed, fall back to syntax highlighting
                 tokens.emplace_back(SemanticToken{var->location.begin, var->location.end, type, lsp::SemanticTokenModifiers::None});
             }
         }