Add flag for no strict DM types in analyze CLI

Author: JohnnyMorganz

CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Fixed
 
 - Fixed forced expressive types in diagnostics
+- Added option `--no-strict-dm-types` for analyze CLI to disable strict datamodel types and its associated false positives
 
 ## [1.19.1] - 2023-04-27
 

src/AnalyzeCli.cpp

@@ -147,6 +147,7 @@ int startAnalyze(int argc, char** argv)
     std::vector<std::filesystem::path> files{};
     std::vector<std::string> ignoreGlobPatterns{};
     std::optional<std::filesystem::path> baseLuaurc = std::nullopt;
+    bool expressiveTypes = true;
 
     for (int i = 2; i < argc; ++i)
     {
@@ -161,6 +162,8 @@ int startAnalyze(int argc, char** argv)
                 annotate = true;
             else if (strcmp(argv[i], "--timetrace") == 0)
                 FFlag::DebugLuauTimeTracing.value = true;
+            else if (strcmp(argv[i], "--no-strict-dm-types") == 0)
+                expressiveTypes = false;
             else if (strncmp(argv[i], "--sourcemap=", 12) == 0)
                 sourcemapPath = std::string(argv[i] + 12);
             else if (strncmp(argv[i], "--definitions=", 14) == 0)
@@ -307,7 +310,7 @@ int startAnalyze(int argc, char** argv)
         }
     }
 
-    types::registerInstanceTypes(frontend, frontend.globals, frontend.globals.globalTypes, fileResolver, /* TODO - expressiveTypes: */ true);
+    types::registerInstanceTypes(frontend, frontend.globals, frontend.globals.globalTypes, fileResolver, expressiveTypes);
 
     Luau::freeze(frontend.globals.globalTypes);
     Luau::freeze(frontend.globalsForAutocomplete.globalTypes);

src/main.cpp

@@ -46,6 +46,8 @@ static bool validateFlag(char* str, int argIndex)
         return true;
     else if (strcmp(str, "--timetrace") == 0)
         return true;
+    else if (strcmp(str, "--no-strict-dm-types") == 0)
+        return true;
     else if (strncmp(str, "--sourcemap=", 12) == 0 && n > 13)
         return true;
     else if (strncmp(str, "--defs=", 7) == 0 && n > 8)
@@ -84,6 +86,7 @@ static void displayHelp(const char* argv0)
     printf("  --formatter=plain: report analysis errors in Luacheck-compatible format\n");
     printf("  --formatter=gnu: report analysis errors in GNU-compatible format\n");
     printf("  --timetrace: record compiler time tracing information into trace.json\n");
+    printf("  --no-strict-dm-types: disable strict DataModel types in type-checking\n");
     printf("  --sourcemap=PATH: path to a Rojo-style sourcemap\n");
     printf("  --definitions=PATH: path to definition file for global types\n");
     printf("  --ignore=GLOB: glob pattern to ignore error outputs\n");