Include the property in the table type definition when finding all references on a property usage

Closes #1166

Author: JohnnyMorganz

CHANGELOG.md

@@ -41,6 +41,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
   local y = x.Property
   ```
 - Rename symbols now works on properties of table types (including across files)
+- Similarly, find all references on a property will now include the original table type definition if it exists. Rename
+  will also modify this table type property name. ([#1166](https://github.com/JohnnyMorganz/luau-lsp/issues/1166))
 
 ### Changed
 

src/operations/References.cpp

@@ -157,6 +157,31 @@ std::vector<Reference> WorkspaceFolder::findAllTableReferences(
                     references.push_back(Reference{moduleName, expr->location});
             }
         }
+
+        for (const auto [type, referencedTy] : module->astResolvedTypes)
+        {
+            if (isSameTable(ty, Luau::follow(referencedTy)))
+            {
+                if (property)
+                {
+                    if (auto typeTable = type->as<Luau::AstTypeTable>())
+                    {
+                        for (const auto& prop : typeTable->props)
+                        {
+                            if (prop.name.value == *property)
+                            {
+                                references.push_back(Reference{moduleName, prop.location});
+                                break;
+                            }
+                        }
+                    }
+                }
+                else
+                {
+                    references.push_back(Reference{moduleName, type->location});
+                }
+            }
+        }
     }
 
     // If its a property, include its original declaration location if not yet found
@@ -671,7 +696,6 @@ lsp::ReferenceResult WorkspaceFolder::references(const lsp::ReferenceParams& par
                 if (prop.location.containsClosed(position))
                 {
                     auto references = findAllTableReferences(Luau::follow(*possibleTableTy), cancellationToken, prop.name.value);
-                    references.push_back(Reference{moduleName, prop.location});
                     return processReferences(fileResolver, references);
                 }
             }

tests/References.test.cpp

@@ -147,6 +147,34 @@ TEST_CASE_FIXTURE(Fixture, "find_references_from_an_inline_table_property_in_a_t
     CHECK_EQ(lsp::Range{{6, 20}, {6, 24}}, result->at(1).range);
 }
 
+TEST_CASE_FIXTURE(Fixture, "find_references_of_a_property_includes_the_original_table_type")
+{
+    // Finding reference of "name" in "T.name"
+    auto source = R"(
+        type Tbl = {
+            name: string
+        }
+
+        local T: Tbl
+        local x = T.name
+    )";
+
+    auto uri = newDocument("foo.luau", source);
+
+    lsp::ReferenceParams params;
+    params.textDocument = lsp::TextDocumentIdentifier{uri};
+    params.position = lsp::Position{6, 22};
+
+    auto result = workspace.references(params, nullptr);
+    REQUIRE(result);
+    REQUIRE_EQ(2, result->size());
+
+    sortResults(result);
+
+    CHECK_EQ(lsp::Range{{2, 12}, {2, 16}}, result->at(0).range);
+    CHECK_EQ(lsp::Range{{6, 20}, {6, 24}}, result->at(1).range);
+}
+
 TEST_CASE_FIXTURE(Fixture, "find_references_of_a_global_function")
 {
     auto source = R"(
@@ -413,6 +441,41 @@ TEST_CASE_FIXTURE(Fixture, "cross_module_find_references_of_an_exported_table_ty
     CHECK_EQ(result->at(1).range, lsp::Range{{4, 20}, {4, 28}});
 }
 
+TEST_CASE_FIXTURE(Fixture, "cross_module_find_references_of_an_exported_table_type_property_when_selecting_a_property_usage")
+{
+    auto uri = newDocument("tbl.luau", R"(
+        export type Table = {
+            Property: string
+        }
+        return {}
+    )");
+
+    auto user = newDocument("user.luau", R"(
+        local tbl = require("tbl.luau")
+
+        local t: tbl.Table
+        local v = t.Property
+    )");
+
+    // Index reverse deps
+    workspace.frontend.parse(workspace.fileResolver.getModuleName(user));
+
+    lsp::ReferenceParams params;
+    params.textDocument = lsp::TextDocumentIdentifier{user};
+    params.position = lsp::Position{4, 23}; // 'Property' usage when indexing 't'
+
+    auto result = workspace.references(params, nullptr);
+    REQUIRE(result);
+    REQUIRE_EQ(2, result->size());
+
+    sortResults(result);
+
+    CHECK_EQ(result->at(0).uri, uri);
+    CHECK_EQ(result->at(0).range, lsp::Range{{2, 12}, {2, 20}});
+    CHECK_EQ(result->at(1).uri, user);
+    CHECK_EQ(result->at(1).range, lsp::Range{{4, 20}, {4, 28}});
+}
+
 TEST_CASE_FIXTURE(Fixture, "references_respect_cancellation")
 {
     auto cancellationToken = std::make_shared<Luau::FrontendCancellationToken>();