Disable roblox types when luau-lsp.platform.type is changed

Fixes #668

Author: JohnnyMorganz

CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Fixed
 
 - The binary on Windows now statically links to the MSVC Runtime to make it more portable ([#657](https://github.com/JohnnyMorganz/luau-lsp/issues/657))
+- Fixed Roblox types still showing when setting `luau-lsp.platform.type` to something other than `roblox`. ([#668](https://github.com/JohnnyMorganz/luau-lsp/issues/668))
 
 ## [1.31.0] - 2024-07-01
 

editors/code/src/roblox.ts

@@ -422,9 +422,12 @@ export const preLanguageServerStart = async (
   // Load roblox type definitions
   const typesConfig = vscode.workspace.getConfiguration("luau-lsp.types");
   const platformConfig = vscode.workspace.getConfiguration("luau-lsp.platform");
+
+  // TODO: Cleanup when deprecated luau-lsp.types.roblox is deleted
+  // We need to respect the new setting as well as the old setting. We check for "&&" since they are on by default
   if (
-    typesConfig.get<boolean>("roblox") ||
-    platformConfig.get<string>("type") === "roblox"
+    platformConfig.get<string>("type") === "roblox" &&
+    typesConfig.get<boolean>("roblox")
   ) {
     const securityLevel =
       typesConfig.get<string>("robloxSecurityLevel") ?? "PluginSecurity";