Use virtual module name when resolving string requires

This fixes a bug where the types of a required file would not correctly
update when that file changed. It is because, during string requires,
we use the real file path as the module name.

However, in other usages (e.g., during indexing), we use the virtual
file path if available. This caused an inconsistency between the two.

We fix this by calling "getModuleName" on the returned URI, which
is consistent with indexing.

Ideally in future, we should move towards a state where the
language server always works in the context of real file paths, especially
as string requires become more common. We should instead only
use a sourcemap to resolve virtual requires to real file paths, rather
than the other way round.

Author: JohnnyMorganz

CHANGELOG.md

@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Fixed
 
 - Fixed autocompletion of strings with '/' characters causing the prefix to be duplicated rather than replaced ([#607](https://github.com/JohnnyMorganz/luau-lsp/issues/607))
+- Fixed bug with string requires where a required files types may not correctly update when the file contents changed
 
 ## [1.28.1] - 2024-03-04
 

src/WorkspaceFileResolver.cpp

@@ -297,7 +297,9 @@ std::optional<Luau::ModuleInfo> WorkspaceFileResolver::resolveStringRequire(cons
     }
 
     // URI-ify the file path so that its normalised (in particular, the drive letter)
-    return {{Uri::parse(Uri::file(filePath).toString()).fsPath().generic_string()}};
+    auto uri = Uri::parse(Uri::file(filePath).toString());
+
+    return Luau::ModuleInfo{getModuleName(uri)};
 }
 
 std::optional<Luau::ModuleInfo> WorkspaceFileResolver::resolveModule(const Luau::ModuleInfo* context, Luau::AstExpr* node)