luau-lsp 1.56.0 hangs when resolving `.config.luau` files that do not complete

[skberkeley]

Hello!

We've had at least 3 folks on the Luau team encounter a hang with the luau-lsp extension indexing files while working on lute. The workaround we've found is to pin the extension to 1.55, suggesting that something changed with 1.56.0 to break things.

[JohnnyMorganz]

Latest released introduced support for parsing .config.luau in analysis mode, but we did not add support for interrupts (as it was not added to luau-analyze yet).

luau-lsp is currently getting stuck in an infinite loop on the file tests/src/require/config_tests/config_luau_timeout/.config.luau

[JohnnyMorganz]

The relevant code location is

luau-lsp/src/WorkspaceFileResolver.cpp

Line 142 in 0db1fc8

return Luau::extractLuauConfig(contents, result, aliasOpts, Luau::InterruptCallbacks{});

Unfortunately I will not get the chance to fix this for a couple weeks.

[vrn-sn]

I had suspected this, but when I tried commenting out the contents of that .config.luau file, I was still noticing the hang (even after trying to reload the plugin). Was something still being cached?

[JohnnyMorganz]

It works fine for me after commenting out the file and saving. Could you try reloading VSCode completely to see if that makes any difference? (Developer: Reload Window)

[vrn-sn]

I was still having issues. What about you @skberkeley? Even with analysis timeouts enabled, this is a purposely malicious test file—is there a way to have luau-lsp ignore it during indexing?

[JohnnyMorganz]

You can use luau-lsp.ignoreGlobs to skip the directory. But if you open a sibling or descendant Luau file you will get stuck again. Make sure all files that might retrieve the config from this malicious file are ignored

[vrn-sn]

Yeah, I just can't seem to make this work. I've even tried deleting the file, disabling luau-lsp in VSCode, and reenabling it. What about you all @skberkeley @annieetang?

[annieetang]

1.56.1 works for me now when I delete the tests/src/require/config_tests/config_luau_timeout/.config.luau and restart the extension!

[vrn-sn]

@JohnnyMorganz happy to consider this issue resolved. I still don't know what's up on my end and will have to keep looking into it separately, but it seems like this works for the others.

Edit: never mind 😄

[annieetang]

Actually sorry, after merging on primary & reloading I'm getting the same issue again...

Would you mind checking again @JohnnyMorganz ?