only validates __callStatic methods now

JohnstonCode · Aug 3, 2018 · 6e0ae41 · 6e0ae41
1 parent 9f45510
commit 6e0ae41
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 126 deletions.
diff --git a/src/Reflection/Money/MoneyMethodReflection.php b/src/Reflection/Money/MoneyMethodReflection.php
diff --git a/src/Reflection/Money/MoneyMethodsReflectionExtension.php b/src/Reflection/Money/MoneyMethodsReflectionExtension.php
@@ -17,20 +17,11 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
 
         $currencies = Currency::getCurrencies();
 
-        return ($classReflection->getNativeReflection()->hasMethod($methodName) || array_key_exists($methodName, $currencies));
+        return array_key_exists($methodName, $currencies);
     }
 
     public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection
     {
-        $currencies = Currency::getCurrencies();
-
-        if (array_key_exists($methodName, $currencies)) {
-            return new MoneyStaticMethodReflection($classReflection, $methodName);
-        }
-
-        $method = $classReflection->getNativeReflection()->getMethod($methodName);
-
-        return new MoneyMethodReflection($classReflection, $methodName, $method->isStatic(), $method->isPrivate());
+        return new MoneyStaticMethodReflection($classReflection, $methodName);
     }
-
 }
diff --git a/tests/Reflection/Money/MoneyMethodsReflectionExtensionTest.php b/tests/Reflection/Money/MoneyMethodsReflectionExtensionTest.php
@@ -16,12 +16,6 @@ protected function setUp(): void
         $this->extension = new MoneyMethodsReflectionExtension();
     }
 
-    public function testHasMethod(): void
-    {
-        $classReflection = $this->broker->getClass('Money\Money');
-        $this->assertTrue($this->extension->hasMethod($classReflection, 'getUnits'));
-    }
-
     public function testHasStaticMethod(): void
     {
         $classReflection = $this->broker->getClass('Money\Money');
@@ -34,38 +28,6 @@ public function testInvalidMethod(): void
         $this->assertFalse($this->extension->hasMethod($classReflection, 'ZZZ'));
     }
 
-    public function testHasPrivateMethod(): void
-    {
-        $classReflection = $this->broker->getClass('Money\Money');
-        $this->assertTrue($this->extension->hasMethod($classReflection, 'assertSameCurrency'));
-    }
-
-    public function testGetPublicMethod(): void
-    {
-        $classReflection = $this->broker->getClass('Money\Money');
-        $methodReflection = $this->extension->getMethod($classReflection, 'getUnits');
-
-        $this->assertEquals('getUnits', $methodReflection->getName());
-        $this->assertEquals($classReflection, $methodReflection->getDeclaringClass());
-        $this->assertFalse($methodReflection->isStatic());
-        $this->assertFalse($methodReflection->isVariadic());
-        $this->assertFalse($methodReflection->isPrivate());
-        $this->assertTrue($methodReflection->isPublic());
-    }
-
-    public function testGetPrivateMethod(): void
-    {
-        $classReflection = $this->broker->getClass('Money\Money');
-        $methodReflection = $this->extension->getMethod($classReflection, 'assertSameCurrency');
-
-        $this->assertEquals('assertSameCurrency', $methodReflection->getName());
-        $this->assertEquals($classReflection, $methodReflection->getDeclaringClass());
-        $this->assertFalse($methodReflection->isStatic());
-        $this->assertFalse($methodReflection->isVariadic());
-        $this->assertTrue($methodReflection->isPrivate());
-        $this->assertFalse($methodReflection->isPublic());
-    }
-
     public function testGetStaticMethod(): void
     {
         $classReflection = $this->broker->getClass('Money\Money');